Add entrance and exit criteria to release template #4083
Conversation
gaiksaya
requested review from
dblock,
peterzhuamazon,
bbarani,
rishabh6788,
zelinh,
jordarlu,
prudhvigodithi,
Divyaasm and
tianleh
as code owners
Codecov Report
@@ Coverage Diff @@
## main #4083 +/- ##
=======================================
Coverage 93.27% 93.27%
=======================================
Files 187 187
Lines 5753 5753
=======================================
Hits 5366 5366
Misses 387 387 |
| Release ticket is cut, and there's a forum post announcing the start of the window | :red_circle: | | | ||
| [Any necessary security reviews](##Security-Reviews) are complete | :red_circle: | | | ||
|
|
||
| ### OpenSearch {{ env.VERSION }} [exit criteria](https://github.com/opensearch-project/.github/blob/main/RELEASING.md#exit-criteria-to-close-release-window) status: |
There was a problem hiding this comment.
@CEHENKLE Should we add "No unpatched vulnerabilities of medium or higher severity that have been publicly known for more than 60 days" to exit criteria as well?
There was a problem hiding this comment.
I put it into exit criteria, but yes :)
There was a problem hiding this comment.
Added this to the exit criteria
| Documentation has been fully reviewed and signed off by the documentation community | :red_circle: | | | ||
| All integration tests are passing | :red_circle: | | | ||
| Release blog is ready | :red_circle: | | | ||
|
|
There was a problem hiding this comment.
Can we add something about all med and high CVEs older than 60 days have been addressed?
There was a problem hiding this comment.
I think we need to add that to the releasing.md as well.
There was a problem hiding this comment.
Should this be in main issue as well as child issues? (Basically build repo issue and all components issues as well?)
There was a problem hiding this comment.
Added to the main issue for now.
There was a problem hiding this comment.
I think it makes sense to push it out to all the repos, but WDYT?
There was a problem hiding this comment.
I believe @bbarani raised a point that if some criteria changes, how do we keep track of all places to change it. Its like how we update dates. We mention them in main issues and refer the child components to go look there.
If the criteria is not gonna be that dynamic then I am okay to add them in child issues too for now. Let me know.
| Release ticket is cut, and there's a forum post announcing the start of the window | :red_circle: | | | ||
| [Any necessary security reviews](##Security-Reviews) are complete | :red_circle: | | | ||
|
|
||
| ### OpenSearch {{ env.VERSION }} [exit criteria](https://github.com/opensearch-project/.github/blob/main/RELEASING.md#exit-criteria-to-close-release-window) status: |
There was a problem hiding this comment.
I put it into exit criteria, but yes :)
Signed-off-by: Sayali Gaikawad <[email protected]>
| Documentation has been fully reviewed and signed off by the documentation community | :red_circle: | | | ||
| All integration tests are passing | :red_circle: | | | ||
| Release blog is ready | :red_circle: | | | ||
|
|
There was a problem hiding this comment.
I think it makes sense to push it out to all the repos, but WDYT?
Description
Add entrance and exit criteria to release template
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.