Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default not to create/update issues during integration test runs #4323

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

peternied
Copy link
Member

Description

In Security we are getting spammed from the concurrent-search-test integration runs. Since I do not plan on supporting runs on this flavor of build I don't want to get issues in our codebase for it.

Note; I'm happy to have issues filed once they've been root caused and our team is at issue, but non-standard builds are not supported by our project and it creates noise.

Issues Resolved

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (810f742) 91.27% compared to head (b3bec56) 91.27%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4323   +/-   ##
=======================================
  Coverage   91.27%   91.27%           
=======================================
  Files         189      189           
  Lines        6163     6163           
=======================================
  Hits         5625     5625           
  Misses        538      538           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -527,7 +528,8 @@ pipeline {
parameters: [
string(name: 'TEST_MANIFEST', value: TEST_MANIFEST),
string(name: 'BUILD_MANIFEST_URL', value: buildManifestUrl),
string(name: 'BUILD_MANIFEST_URL_OPENSEARCH', value: buildManifestUrlOpenSearch)
string(name: 'BUILD_MANIFEST_URL_OPENSEARCH', value: buildManifestUrlOpenSearch),
booleanParam(name: 'UPDATE_GITHUB_ISSUES', value: true)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default it to false maybe?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the distribution build job - we want it to keep sending notifications, no? Are any 'unsupported' jobs run with this task?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry missed the fact that this is a distribution build job. I think we might re-think the logic once #4301 feature support is added.

Copy link
Member

@gaiksaya gaiksaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this.

@peternied peternied merged commit c70ce17 into opensearch-project:main Jan 4, 2024
14 checks passed
@peternied peternied deleted the create-issue-param branch January 4, 2024 21:30
@peternied
Copy link
Member Author

@gaiksaya Looks like I see another notification [1] from last nights scheduled run. Taking a quick peak at a recent run's logs [2] [3], I don't see the new parameters - is there anything that needs to be done to deploy this change?

@prudhvigodithi
Copy link
Member

Hey @peternied works as expected based on you change right?, I did notice the integ test 6894 has the parameter UPDATE_GITHUB_ISSUES as the upstream job is distribution build https://build.ci.opensearch.org/job/distribution-build-opensearch/9143 where UPDATE_GITHUB_ISSUES is defaulted to true.
Screenshot 2024-01-05 at 8 01 26 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants