-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default not to create/update issues during integration test runs #4323
Default not to create/update issues during integration test runs #4323
Conversation
Signed-off-by: Peter Nied <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4323 +/- ##
=======================================
Coverage 91.27% 91.27%
=======================================
Files 189 189
Lines 6163 6163
=======================================
Hits 5625 5625
Misses 538 538 ☔ View full report in Codecov by Sentry. |
@@ -527,7 +528,8 @@ pipeline { | |||
parameters: [ | |||
string(name: 'TEST_MANIFEST', value: TEST_MANIFEST), | |||
string(name: 'BUILD_MANIFEST_URL', value: buildManifestUrl), | |||
string(name: 'BUILD_MANIFEST_URL_OPENSEARCH', value: buildManifestUrlOpenSearch) | |||
string(name: 'BUILD_MANIFEST_URL_OPENSEARCH', value: buildManifestUrlOpenSearch), | |||
booleanParam(name: 'UPDATE_GITHUB_ISSUES', value: true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Default it to false maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the distribution build job - we want it to keep sending notifications, no? Are any 'unsupported' jobs run with this task?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry missed the fact that this is a distribution build job. I think we might re-think the logic once #4301 feature support is added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this.
@gaiksaya Looks like I see another notification [1] from last nights scheduled run. Taking a quick peak at a recent run's logs [2] [3], I don't see the new parameters - is there anything that needs to be done to deploy this change?
|
Hey @peternied works as expected based on you change right?, I did notice the integ test |
Description
In Security we are getting spammed from the
concurrent-search-test
integration runs. Since I do not plan on supporting runs on this flavor of build I don't want to get issues in our codebase for it.Note; I'm happy to have issues filed once they've been root caused and our team is at issue, but non-standard builds are not supported by our project and it creates noise.
Issues Resolved
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.