Fix pytests and update build.sh to add ppc64le support. #4413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sunidhi-Gaonkar1
requested review from
dblock,
peterzhuamazon,
bbarani,
gaiksaya,
rishabh6788,
zelinh,
jordarlu,
prudhvigodithi,
Divyaasm and
tianleh
as code owners
peterzhuamazon
approved these changes
Feb 6, 2024
|
@Sunidhi-Gaonkar1 do you want to also upgrade pyyaml to 6.0.1 in the same PR? Thanks. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4413 +/- ##
==========================================
+ Coverage 91.35% 91.55% +0.20%
==========================================
Files 190 190
Lines 6175 6216 +41
==========================================
+ Hits 5641 5691 +50
+ Misses 534 525 -9 ☔ View full report in Codecov by Sentry. |
peterzhuamazon
requested changes
Feb 6, 2024
| @@ -14,7 +14,7 @@ | |||
| class TestOs(unittest.TestCase): | |||
| # current_architecture | |||
| def test_current_architecture(self) -> None: | |||
| self.assertTrue(current_architecture() in ["x64", "arm64"]) | |||
| self.assertTrue(current_architecture() in ["x64", "arm64", "ppc64le"]) | |||
There was a problem hiding this comment.
@Sunidhi-Gaonkar1 you need to add one more test case:
src/system/os.py#L19
Added line #L19 was not covered by tests
There was a problem hiding this comment.
@peterzhuamazon ,I have made the changes, Please review. Thank you.
Signed-off-by: Sunidhi-Gaonkar1 <[email protected]>
Sunidhi-Gaonkar1
force-pushed
the
ppc64le
branch
from
13972b9 to
2dcf348
Compare
Signed-off-by: Peter Zhu <[email protected]>
|
Hi @Sunidhi-Gaonkar1 ,
|
|
Hi @peterzhuamazon, We don't have a macos server to reproduce this issue. Please let me know how we can |
@Sunidhi-Gaonkar1 this is not macos issue you can just run pipenv intall with your latest pipfile changes, build the new pipfile.lock, and run pipenv run pytest to see the above issue. I was running on linux to see this issue. I was saying do not run isort on macos run it on linux. isort is not the same as pytest. |
|
@peterzhuamazon, I have followed your instructions to build the Pipfile.lock with latest changes and run pytests on linux |
Taking a look, I am not able to pass on both my mac and my AL2 server 😅 Thanks. |
Signed-off-by: Peter Zhu <[email protected]>
|
Seems like my push of the new pipefile.lock runs well. |
peterzhuamazon
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding ppc64le build target to build.sh
Issues Resolved
Fixes the pytest errors faced in #4348
Part of #3122
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.