Fix the bundle_artifact_path value and remove wrong comments for deb assemble #4673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…assemble Signed-off-by: Peter Zhu <[email protected]>
peterzhuamazon
added
bug
peterzhuamazon
requested review from
dblock,
bbarani,
gaiksaya,
rishabh6788,
zelinh,
jordarlu,
prudhvigodithi,
Divyaasm and
tianleh
as code owners
zelinh
reviewed
May 2, 2024
| # for dirpath, dirnames, filenames in os.walk(os.path.join('/tmp/opensearch*')): | ||
| # In debuild, the final package is created in the parent directory of the sources | ||
| # https://github.com/opensearch-project/opensearch-build/issues/4532#issuecomment-2091726868 | ||
| bundle_artifact_path = f"/tmp/{self.filename}_{deb_version}_{deb_architecture(build_cls.architecture)}.deb" |
There was a problem hiding this comment.
It is same, but in previous implementation the var bundle_artifact_path is missing assignment other than None, resulted in:
2024-03-14 17:05:15 INFO Found deb file: None
Now:
2024-05-02 21:50:15 INFO Found deb file: /tmp/opensearch_2.14.0_amd64.deb
Thanks.
There was a problem hiding this comment.
Make sense. I see it doesn't assign any value after line 100. Thanks @peterzhuamazon
zelinh
approved these changes
May 2, 2024
| # for dirpath, dirnames, filenames in os.walk(os.path.join('/tmp/opensearch*')): | ||
| # In debuild, the final package is created in the parent directory of the sources | ||
| # https://github.com/opensearch-project/opensearch-build/issues/4532#issuecomment-2091726868 | ||
| bundle_artifact_path = f"/tmp/{self.filename}_{deb_version}_{deb_architecture(build_cls.architecture)}.deb" |
There was a problem hiding this comment.
Make sense. I see it doesn't assign any value after line 100. Thanks @peterzhuamazon
This was referenced May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the bundle_artifact_path value and remove wrong comments for deb assemble
Issues Resolved
Closes #4532
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.