Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Result Publisher #938

Merged

Conversation

owaiskazi19
Copy link
Member

@owaiskazi19 owaiskazi19 commented Nov 10, 2021

Description

  • Implemented Result Publisher to store result of the test to S3.
  • Path to test-results bundlebuild/${opensearch_version}/${build_id}/${platform}/${architecture}/test-results/test_run_id/test_type/component.
  • Added platform as a build parameter.
  • Fixed run command for Integ Test to execute without S3 dependencies

Ref: #207 for the discussion.

Issues Resolved

#341

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@owaiskazi19 owaiskazi19 requested a review from a team as a code owner November 10, 2021 22:20
@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2021

Codecov Report

Merging #938 (4ed9690) into main (9745ddc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #938   +/-   ##
=======================================
  Coverage   92.24%   92.25%           
=======================================
  Files          88       88           
  Lines        2321     2323    +2     
=======================================
+ Hits         2141     2143    +2     
  Misses        180      180           
Impacted Files Coverage Δ
src/run_integ_test.py 92.68% <100.00%> (+0.37%) ⬆️
src/test_workflow/test_recorder/test_recorder.py 46.26% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9745ddc...4ed9690. Read the comment docs.

@owaiskazi19 owaiskazi19 force-pushed the test-publisher-jenkins branch from 694e36d to faed340 Compare November 10, 2021 22:26
test.sh Outdated
@@ -9,6 +9,7 @@
set -e

DIR="$(dirname "$0")"
mkdir -p 'test-results'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do this in code before we write results like for all the other paths (we create directories for builds and dist).

@owaiskazi19 owaiskazi19 force-pushed the test-publisher-jenkins branch 2 times, most recently from 436cacf to 4ed9690 Compare November 10, 2021 23:55
@owaiskazi19 owaiskazi19 requested a review from dblock November 10, 2021 23:58
@owaiskazi19 owaiskazi19 force-pushed the test-publisher-jenkins branch from 4ed9690 to abc9cfa Compare November 11, 2021 00:07
@owaiskazi19 owaiskazi19 force-pushed the test-publisher-jenkins branch from abc9cfa to 28472bf Compare November 11, 2021 00:44
@owaiskazi19 owaiskazi19 requested a review from gaiksaya November 11, 2021 00:52
@@ -59,13 +60,28 @@ pipeline {
}
}
steps {
sh "./test.sh ${JOB_NAME} --s3-bucket ${ARTIFACT_BUCKET_NAME} --opensearch-version ${opensearch_version} --build-id ${build_id} --architecture ${architecture} --test-run-id ${test_run_id}"
script {
basePath = "https://ci.opensearch.org/ci/dbc/bundle-build/${opensearch_version}/${build_id}/${platform}/${architecture}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make this a parameter to the job? We just had a build break yesterday night due to building these paths inconsistently

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://ci.opensearch.org/ci/dbc/bundle-build/should be a parameter to the job?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even more - basePath = "https://ci.opensearch.org/ci/dbc/bundle-build/${opensearch_version}/${build_id}/${platform}/${architecture}" could be passed in a parameter, only the architecture is used to determine the agent node type all the rest of the values are passed around to no effect.

...lets come back to this after you merge to build momentum

@@ -59,13 +60,28 @@ pipeline {
}
}
steps {
sh "./test.sh ${JOB_NAME} --s3-bucket ${ARTIFACT_BUCKET_NAME} --opensearch-version ${opensearch_version} --build-id ${build_id} --architecture ${architecture} --test-run-id ${test_run_id}"
script {
basePath = "https://ci.opensearch.org/ci/dbc/bundle-build/${opensearch_version}/${build_id}/${platform}/${architecture}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even more - basePath = "https://ci.opensearch.org/ci/dbc/bundle-build/${opensearch_version}/${build_id}/${platform}/${architecture}" could be passed in a parameter, only the architecture is used to determine the agent node type all the rest of the values are passed around to no effect.

...lets come back to this after you merge to build momentum

Copy link
Member

@gaiksaya gaiksaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@owaiskazi19 owaiskazi19 merged commit a985057 into opensearch-project:main Nov 11, 2021
@owaiskazi19 owaiskazi19 changed the title Added Test Publisher Added Result Publisher Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants