-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Result Publisher #938
Added Result Publisher #938
Conversation
Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #938 +/- ##
=======================================
Coverage 92.24% 92.25%
=======================================
Files 88 88
Lines 2321 2323 +2
=======================================
+ Hits 2141 2143 +2
Misses 180 180
Continue to review full report at Codecov.
|
694e36d
to
faed340
Compare
test.sh
Outdated
@@ -9,6 +9,7 @@ | |||
set -e | |||
|
|||
DIR="$(dirname "$0")" | |||
mkdir -p 'test-results' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do this in code before we write results like for all the other paths (we create directories for builds and dist).
436cacf
to
4ed9690
Compare
4ed9690
to
abc9cfa
Compare
Signed-off-by: Owais Kazi <[email protected]>
abc9cfa
to
28472bf
Compare
@@ -59,13 +60,28 @@ pipeline { | |||
} | |||
} | |||
steps { | |||
sh "./test.sh ${JOB_NAME} --s3-bucket ${ARTIFACT_BUCKET_NAME} --opensearch-version ${opensearch_version} --build-id ${build_id} --architecture ${architecture} --test-run-id ${test_run_id}" | |||
script { | |||
basePath = "https://ci.opensearch.org/ci/dbc/bundle-build/${opensearch_version}/${build_id}/${platform}/${architecture}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make this a parameter to the job? We just had a build break yesterday night due to building these paths inconsistently
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://ci.opensearch.org/ci/dbc/bundle-build/
should be a parameter to the job?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even more - basePath = "https://ci.opensearch.org/ci/dbc/bundle-build/${opensearch_version}/${build_id}/${platform}/${architecture}"
could be passed in a parameter, only the architecture is used to determine the agent node type all the rest of the values are passed around to no effect.
...lets come back to this after you merge to build momentum
@@ -59,13 +60,28 @@ pipeline { | |||
} | |||
} | |||
steps { | |||
sh "./test.sh ${JOB_NAME} --s3-bucket ${ARTIFACT_BUCKET_NAME} --opensearch-version ${opensearch_version} --build-id ${build_id} --architecture ${architecture} --test-run-id ${test_run_id}" | |||
script { | |||
basePath = "https://ci.opensearch.org/ci/dbc/bundle-build/${opensearch_version}/${build_id}/${platform}/${architecture}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even more - basePath = "https://ci.opensearch.org/ci/dbc/bundle-build/${opensearch_version}/${build_id}/${platform}/${architecture}"
could be passed in a parameter, only the architecture is used to determine the agent node type all the rest of the values are passed around to no effect.
...lets come back to this after you merge to build momentum
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Description
bundlebuild/${opensearch_version}/${build_id}/${platform}/${architecture}/test-results/test_run_id/test_type/component
.platform
as a build parameter.Ref: #207 for the discussion.
Issues Resolved
#341
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.