-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Upgrade jenkins] Switch to java 11 as default java version on agent nodes #277
Conversation
Need to confirm that java8 is completely removed on gradle check: |
After some discussion there might still be some requirements for JDK8 on gradle check bwc tests. Thanks. |
Looks like I did not remove java8 from ubuntu and windows. However I did remove it from AL2 and macos. Do you want me to add back? Might need to figure out a way to set java 11 as default |
If that is the case just go ahead with the merge. Thanks. |
#Set java to JDK11 so Jenkins can bootstrap it | ||
sudo update-alternatives --set "java" "/usr/lib/jvm/java-11-openjdk-11.0.18.0.10-1.amzn2.0.1.x86_64/bin/java" | ||
sudo update-alternatives --set "javac" "/usr/lib/jvm/java-11-openjdk-11.0.18.0.10-1.amzn2.0.1.x86_64/bin/java" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This wont run on the arm64 server.
I would say just ignore jdk8 on non-ubuntu / non-windows for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right! Forgot about that. Will revert to previous state then. Moving on without jdk8 on al2 then
Signed-off-by: Sayali Gaikawad <[email protected]>
The following templates will be used to rebuild the AMIs with this setup:
|
Description
Switch to java 11 as default java version on agent nodes. Required for newer jenkins version.
Ubuntu: Contains everything as before but default changed to java 11
Windows: Contains everything as before but default changed to java 11
MacOS: Contains only java 11 now
AL2: Contains only java 11 now
Issues Resolved
Part of #261
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.