-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wait for tenancy call if security enabled and bump version #230
Wait for tenancy call if security enabled and bump version #230
Conversation
Bumping to version 2.0.0, fix linter problem. Also, preventing the test runner from navigating to a new page when security plugin is enabled. The reason why is because depending on how long the test takes to run, there is an API call to refresh the permissions that take a little bit longer than what tests are expecting. So if the test runner makes the call to switch tenants but navigates to a new page before that call is finished another call might run into a permissions error. This ensures that if that call is made then the test runner waits before navigating to the destination. Issue: opensearch-project#231 Signed-off-by: Kawika Avilla <[email protected]>
58fe235
to
5a8f44a
Compare
Failures would be due to chicken and egg problem. Needs a 2.0 build but this needs to be in the 2.0 build. |
By checking the error in this check, https://github.com/opensearch-project/opensearch-dashboards-functional-test/runs/6514651442?check_suite_focus=true , the error is
It is related to the breaking change where @kavilla Since you already have the version bump in this PR, can you add such authentication along the way? We already have an existing example for 9200 check . |
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
@tianleh seeing some issues. but might be related to the current existing failures from AD and Observability. The other PR might help but I believe both plugins are working on it. |
@kavilla @tianleh I vote for merging this PR now:
|
Description
Bumping to version 2.0.0, fix linter problem.
Also, preventing the test runner from navigating to a new
page when security plugin is enabled. The reason why is
because depending on how long the test takes to run, there
is an API call to refresh the permissions that take a little
bit longer than what tests are expecting. So if the test runner
makes the call to switch tenants but navigates to a new page
before that call is finished another call might run into a
permissions error. This ensures that if that call is made
then the test runner waits before navigating to the destination.
Signed-off-by: Kawika Avilla [email protected]
Issues Resolved
#231
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.