Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for tenancy call if security enabled and bump version #230

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented May 19, 2022

Description

Bumping to version 2.0.0, fix linter problem.

Also, preventing the test runner from navigating to a new
page when security plugin is enabled. The reason why is
because depending on how long the test takes to run, there
is an API call to refresh the permissions that take a little
bit longer than what tests are expecting. So if the test runner
makes the call to switch tenants but navigates to a new page
before that call is finished another call might run into a
permissions error. This ensures that if that call is made
then the test runner waits before navigating to the destination.

Signed-off-by: Kawika Avilla [email protected]

Issues Resolved

#231

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@kavilla kavilla requested a review from a team as a code owner May 19, 2022 20:28
@kavilla kavilla linked an issue May 19, 2022 that may be closed by this pull request
Bumping to version 2.0.0, fix linter problem.

Also, preventing the test runner from navigating to a new
page when security plugin is enabled. The reason why is
because depending on how long the test takes to run, there
is an API call to refresh the permissions that take a little
bit longer than what tests are expecting. So if the test runner
makes the call to switch tenants but navigates to a new page
before that call is finished another call might run into a
permissions error. This ensures that if that call is made
then the test runner waits before navigating to the destination.

Issue:
opensearch-project#231

Signed-off-by: Kawika Avilla <[email protected]>
@kavilla kavilla force-pushed the avillk/handle_visit_with_security branch from 58fe235 to 5a8f44a Compare May 19, 2022 20:34
@kavilla
Copy link
Member Author

kavilla commented May 19, 2022

Failures would be due to chicken and egg problem. Needs a 2.0 build but this needs to be in the 2.0 build.

@tianleh
Copy link
Member

tianleh commented May 20, 2022

Failures would be due to chicken and egg problem. Needs a 2.0 build but this needs to be in the 2.0 build.

By checking the error in this check, https://github.com/opensearch-project/opensearch-dashboards-functional-test/runs/6514651442?check_suite_focus=true , the error is

{"type":"response","@timestamp":"2022-05-19T20:43:07Z","tags":["api"],"pid":2089,"method":"get","statusCode":401,"req":{"url":"/api/status","method":"get","headers":{"host":"localhost:5601","user-agent":"curl/7.68.0","accept":"*/*"},"remoteAddress":"127.0.0.1","userAgent":"curl/7.68.0"},"res":{"statusCode":401,"responseTime":1,"contentLength":9},"message":"GET /api/status 401 1ms - 9.0B"}

It is related to the breaking change where /api/status needs authentication.( opensearch-project/opensearch-build#2112 (comment))

@kavilla Since you already have the version bump in this PR, can you add such authentication along the way? We already have an existing example for 9200 check .

cc @seraphjiang @CCongWang @peterzhuamazon

kavilla added 2 commits May 23, 2022 17:53
@kavilla
Copy link
Member Author

kavilla commented May 23, 2022

@tianleh seeing some issues. but might be related to the current existing failures from AD and Observability. The other PR might help but I believe both plugins are working on it.

@peterzhuamazon
Copy link
Member

@kavilla @tianleh I vote for merging this PR now:

  1. OBS Add data-test-subj to app analytics tests #216 is waiting for this PR to merge.
  2. ADDash is also waiting for this to verify their test again.
    Thanks.

@tianleh
Copy link
Member

tianleh commented May 23, 2022

@kavilla @tianleh I vote for merging this PR now:

1. OBS

+1

@peterzhuamazon peterzhuamazon merged commit 082a230 into opensearch-project:main May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Intermittent failures when security plugin enabled
3 participants