Re-enable integration tests across multiple versions of OpenSearch #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblock
force-pushed
the
integration-opensearch-1.x
branch
2 times, most recently
from
2eb2732 to
ee9d6a1
Compare
dblock
force-pushed
the
integration-opensearch-1.x
branch
2 times, most recently
from
bad7dcf to
7c55d46
Compare
dblock
changed the title
dblock
changed the title
VachaShah
reviewed
Apr 26, 2022
| @@ -17,18 +17,23 @@ jobs: | |||
| strategy: | |||
| fail-fast: false | |||
| matrix: | |||
| java: [ 11 ] | |||
| entry: | |||
| - { opensearch_ref: '1.x', java: 11 } | |||
There was a problem hiding this comment.
Do we want to test against 1.x branch as well?
There was a problem hiding this comment.
We may be releasing security patches, e.g. 1.3.2, so yes.
Signed-off-by: dblock <[email protected]>
Signed-off-by: dblock <[email protected]>
Signed-off-by: dblock <[email protected]>
Signed-off-by: dblock <[email protected]>
Signed-off-by: dblock <[email protected]>
Signed-off-by: dblock <[email protected]>
Signed-off-by: dblock <[email protected]>
dblock
force-pushed
the
integration-opensearch-1.x
branch
from
b2bf824 to
5fcddec
Compare
VachaShah
previously approved these changes
Apr 26, 2022
VachaShah
reviewed
Apr 29, 2022
| - { opensearch_version: 1.2.2, java: 11 } | ||
| - { opensearch_version: 1.2.3, java: 11 } | ||
| - { opensearch_version: 1.2.4, java: 11 } | ||
| - { opensearch_version: 1.3.0, java: 11 } |
There was a problem hiding this comment.
Sorry I missed this earlier, you can also add 1.3.1 in here - on 1.x branch we have https://github.com/opensearch-project/opensearch-java/blob/1.x/.github/workflows/test-integration.yml.
Signed-off-by: dblock <[email protected]>
Signed-off-by: dblock <[email protected]>
VachaShah
approved these changes
May 3, 2022
saratvemulapalli
approved these changes
May 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: dblock [email protected]
Description
Issues Resolved
Partially addresses #152.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.