[2.0]Change the "Blacklist / Whitelist" nomenclature in nodejs client

[ananzh]

Replace the terminology "blacklist" with "denylist".
Replace the terminology "whitelist" with "allowlist".

Signed-off-by: Anan Zhuang [email protected]

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[boktorbb]

Can we keep terminology consistent between repos and use blocklist instead of denylist here? I believe we're using blocklist in the core dashboards repo

[ananzh]

blocklist instead of denylist here? I believe we're using blocklist in the core dashboards repo

Thanks Bishoy for commenting on this. I am a bit confused here, in this OpenSearch PR, it specifies:

Replace the old usages that having "blacklist/whitelist" in configurations with "denylist/allowlist", then create duplicate usages with the old terminology for backwards compatibility (including fallback logic to fallback to settings with the new name).

Also in OpenSearch code base, for example, in 2.x and current main:

private final ConcurrentMap<HttpHost, DeadHostState> denylist = new ConcurrentHashMap<>();

Code reference:
https://github.com/opensearch-project/OpenSearch/blob/40fc71cd3f1c5607bc3781ea9d11c16716b5ced3/client/rest/src/main/java/org/opensearch/client/RestClient.java#L128

Where did you see blocklist?

[boktorbb]

blocklist instead of denylist here? I believe we're using blocklist in the core dashboards repo

Thanks Bishoy for commenting on this. I am a bit confused here, in this OpenSearch PR, it specifies:

Replace the old usages that having "blacklist/whitelist" in configurations with "denylist/allowlist", then create duplicate usages with the old terminology for backwards compatibility (including fallback logic to fallback to settings with the new name).

Also in OpenSearch code base, for example, in 2.x and current main:

private final ConcurrentMap<HttpHost, DeadHostState> denylist = new ConcurrentHashMap<>();

Code reference: https://github.com/opensearch-project/OpenSearch/blob/40fc71cd3f1c5607bc3781ea9d11c16716b5ced3/client/rest/src/main/java/org/opensearch/client/RestClient.java#L128

Where did you see blocklist?

There are several references to blocklist in the core dashboards repo. One customer facing example is for the Graphite blocklist feature

[ananzh]

Apparently, we have used both blocklist and denylist in OS. I will check with OS. I think the changes here are good but we might need to clean up OSD to make some consistency.

[dblock]

cc: @tlfeng in case we have the nomenclature confused somewhere

[tmarkley]

I think allowlist/denylist works well!