Added more serializer/deserializer tests. #559
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblock
requested review from
ananzh,
kavilla,
seanneumann,
VachaShah,
nhtruong,
harshavamsi and
timursaurus
as code owners
dblock
changed the title
nhtruong
reviewed
Jul 13, 2023
| `"a": "෴1111111111111111",` + | ||
| `"b": "߷1111111111111111",` + | ||
| `"c": "֍1111111111111111",` + | ||
| `"d": "෴֍߷1111111111111111"` + | ||
| `}`; |
There was a problem hiding this comment.
Don't you want to add the expected outputs like t.equal(obj.hardcoded, 102931203123987); on line 71?
There was a problem hiding this comment.
I will be adding similar ones in my other PR. I would recommend we hold off on these.
Signed-off-by: dblock <[email protected]>
dblock
force-pushed
the
test-deserializer
branch
from
ba94412 to
c1d6ab4
Compare
|
@AMoo-Miki feel free to close this one if you have better |
|
#557 is better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Coming from #558. Are there cases that would still fail?
Check List
yarn run lintdoesn't show any errorsBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.