Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert Search_Response #943

Conversation

paul-uz
Copy link

@paul-uz paul-uz commented Dec 18, 2024

Reverted a change between beta.7 and beta.8 that broke the Search_Response typings.

Closes #942

@nhtruong
Copy link
Collaborator

Thanks. That file is actually generated via the api_generator. So changes must be made in the generator and then regenerate the API

@paul-uz
Copy link
Author

paul-uz commented Dec 18, 2024

Thanks. That file is actually generated via the api_generator. So changes must be made in the generator and then regenerate the API

Would you be able to point me in the right direction on how to do so? Ta

@nhtruong
Copy link
Collaborator

Here is where most of the changes will have to be made but it's not easy. My memory on this is till pretty fresh so I'll tackle this.

@nhtruong nhtruong closed this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No typings on search body, other than Record<string, any>
2 participants