Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding details for auto backport #123

Merged
merged 4 commits into from
Feb 16, 2022

Conversation

VachaShah
Copy link
Collaborator

Signed-off-by: Vacha Shah [email protected]

Description

Coming from #108 (comment), adding details for auto backport in a .md file.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@VachaShah VachaShah requested a review from a team February 11, 2022 00:08
Signed-off-by: Vacha Shah <[email protected]>
META.md Outdated
- [Remaining Plugins](#remaining-plugins)
- [Update job-scheduler Snapshots](#update-job-scheduler-snapshots)
- [Update the Manifest](#update-the-manifest)
- [Backporting in OpenSearch Plugins](#backporting-in-opensearch-plugins)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't find a better place, but Meta.md doesnt feel like the right place to have the backport workflows.
May be https://github.com/opensearch-project/opensearch-plugins/blob/main/STANDARDS.md?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah you are right. It doesn't look right in META.md. What do you think between STANDARDS.md and CONTRIBUTING.md?

@dblock
Copy link
Member

dblock commented Feb 14, 2022

I think that the developer part of how to use backporting should go into CONTRIBUTING.md and the admin part of how to set it up should go into https://github.com/opensearch-project/.github/blob/main/MAINTAINERS.md - that's where we tell maintainers to enable CI and DCO.

@dblock
Copy link
Member

dblock commented Feb 14, 2022

Also, a blog post on adopting backport automation would be great for the blog!

@VachaShah
Copy link
Collaborator Author

I think that the developer part of how to use backporting should go into CONTRIBUTING.md and the admin part of how to set it up should go into https://github.com/opensearch-project/.github/blob/main/MAINTAINERS.md - that's where we tell maintainers to enable CI and DCO.

MAINTAINERS.md sounds like a good place for it. CONTRIBUTING.md might not be applicable since auto backports require adding labels to PRs and the Review Process says the maintainers will take care of backporting. WDYT?

@VachaShah
Copy link
Collaborator Author

Also, a blog post on adopting backport automation would be great for the blog!

Yes, I am going to work on drafting a blog for this.

@dblock
Copy link
Member

dblock commented Feb 14, 2022

I think that the developer part of how to use backporting should go into CONTRIBUTING.md and the admin part of how to set it up should go into https://github.com/opensearch-project/.github/blob/main/MAINTAINERS.md - that's where we tell maintainers to enable CI and DCO.

MAINTAINERS.md sounds like a good place for it. CONTRIBUTING.md might not be applicable since auto backports require adding labels to PRs and the Review Process says the maintainers will take care of backporting. WDYT?

Yep, you're right.

Copy link
Member

@saratvemulapalli saratvemulapalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work @VachaShah !!

Dropped a minor suggestion, I'm ok merging the PR as is.


To use the auto backport workflow:

1. Label the original PR according to the release-branch. For example, to backport to 1.x , please add a label `backport 1.x`. You can add multiple backport labels to different release branches. Labels can be added in any order: meaning before or after the PR is merged.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An example PR would be nice to look at.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I added an example after the usage section.

Signed-off-by: Vacha Shah <[email protected]>
@dblock dblock merged commit fb65d35 into opensearch-project:main Feb 16, 2022
@VachaShah VachaShah deleted the backport-doc branch February 18, 2022 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants