Fix for 592 #594
Fix for 592 #594
Conversation
Signed-off-by: dblock <[email protected]>
Signed-off-by: dblock <[email protected]>
dblock
requested review from
VachaShah,
harshavamsi,
axeoman,
deztructor,
Shephalimittal,
saimedhi and
florianvazelle
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #594 +/- ##
==========================================
- Coverage 71.87% 71.86% -0.02%
==========================================
Files 89 89
Lines 7922 7932 +10
==========================================
+ Hits 5694 5700 +6
- Misses 2228 2232 +4 ☔ View full report in Codecov by Sentry. |
| @@ -45,6 +45,14 @@ | |||
| @nox.session(python=["3.6", "3.7", "3.8", "3.9", "3.10", "3.11"]) # type: ignore | |||
| def test(session: Any) -> None: | |||
| session.install(".") | |||
| # ensure client can be imported without aiohttp | |||
| session.run("python", "-c", "import opensearchpy\nprint(opensearchpy.OpenSearch())") | |||
There was a problem hiding this comment.
This reproduces #592 without the fix.
There was a problem hiding this comment.
I have full faith that this should work, but looking through the tests I don't think we do a nox test in any of the CIs. I think we really need to add that.
| @@ -45,6 +45,14 @@ | |||
| @nox.session(python=["3.6", "3.7", "3.8", "3.9", "3.10", "3.11"]) # type: ignore | |||
| def test(session: Any) -> None: | |||
| session.install(".") | |||
| # ensure client can be imported without aiohttp | |||
| session.run("python", "-c", "import opensearchpy\nprint(opensearchpy.OpenSearch())") | |||
There was a problem hiding this comment.
I have full faith that this should work, but looking through the tests I don't think we do a nox test in any of the CIs. I think we really need to add that.
Signed-off-by: dblock <[email protected]>
|
@harshavamsi You are absolutely right. Switch to using nox in CI. |
There was a problem hiding this comment.
Looking at a random run I see that nox is picking up opensearch from the install. LGTM!
* Prepare for next developer iteration, 2.4.1. Signed-off-by: dblock <[email protected]> * Fix: sync opensearchpy without iohttp. Signed-off-by: dblock <[email protected]> * Use nox to run tests. Signed-off-by: dblock <[email protected]> --------- Signed-off-by: dblock <[email protected]> Signed-off-by: roma2023 <[email protected]>
Description
Go back to try/catch for requiring async code.
Issues Resolved
Closes #592.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.