Sigv4 Wrapper Gem for OpenSearch::Client #104
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblock
reviewed
Oct 20, 2022
dblock
previously approved these changes
Oct 20, 2022
|
I hit approve. Big (and definitely a late) question. Should this be called |
|
Will need to get a CHANGELOG line, too. |
@dblock It should haha. You will likely have to hit approve a 3rd time though :P |
Signed-off-by: Theo Truong <[email protected]>
dblock
previously approved these changes
Oct 21, 2022
nhtruong
requested review from
VijayanB,
jayeshathila and
vamshin
as code owners
Signed-off-by: Theo Truong <[email protected]>
dblock
approved these changes
Oct 26, 2022
|
@robsears @VijayanB @jayeshathila @vamshin Would you mind taking a look at this? |
|
This is being blocked by: #108 |
VachaShah
reviewed
Nov 2, 2022
| s.required_ruby_version = '>= 2.5' | ||
|
|
||
| s.add_dependency 'aws-sigv4', '~> 1' | ||
| s.add_dependency 'opensearch-ruby', '~> 2' |
There was a problem hiding this comment.
Since this new opensearch-aws-sigv4 gem is independent, can it work with both 1.x and 2.x versions of opensearch-ruby gem?
There was a problem hiding this comment.
It might. Lemme take a look at v1 to see if it will cause any issue.
|
New Commit is not being pushed to this PR. Recreating. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Theo Truong [email protected]
Description
Added Sigv4 Client gem that is a wrapper of
opensearch-rubygem. This gem will sign every request with an AWS Sigv4 signature.Issues Resolved
Closes #71
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.