-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] In dark mode, auto-populated fields are tough to see #870
Labels
bug
Something isn't working
Comments
AMoo-Miki
added a commit
to AMoo-Miki/oui
that referenced
this issue
Jul 1, 2023
Fixes opensearch-project#870 Signed-off-by: Miki <[email protected]>
7 tasks
BSFishy
pushed a commit
that referenced
this issue
Jul 20, 2023
* Fix `autofill` text color in dark themes Fixes #870 Signed-off-by: Miki <[email protected]> * Use ouiTextColor in next theme Signed-off-by: Josh Romero <[email protected]> --------- Signed-off-by: Miki <[email protected]> Signed-off-by: Josh Romero <[email protected]> Co-authored-by: Josh Romero <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this issue
Jul 20, 2023
* Fix `autofill` text color in dark themes Fixes #870 Signed-off-by: Miki <[email protected]> * Use ouiTextColor in next theme Signed-off-by: Josh Romero <[email protected]> --------- Signed-off-by: Miki <[email protected]> Signed-off-by: Josh Romero <[email protected]> Co-authored-by: Josh Romero <[email protected]> (cherry picked from commit f718f63) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
joshuarrrr
pushed a commit
that referenced
this issue
Jul 20, 2023
* Fix `autofill` text color in dark themes Fixes #870 Signed-off-by: Miki <[email protected]> * Use ouiTextColor in next theme Signed-off-by: Josh Romero <[email protected]> --------- Signed-off-by: Miki <[email protected]> Signed-off-by: Josh Romero <[email protected]> Co-authored-by: Josh Romero <[email protected]> (cherry picked from commit f718f63) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Input fields that are auto-populated by the browser, like a saved usernames, are too dark to see in the dark mode for both default and Next themes. That is because the "shades" are reversed in dark mode where
$ouiColorLightestShade
is in fact nearly black and$ouiColorDarkestShade
is nearly while. The code below wrongly uses$ouiColorLightShade
, which is a dark color, on a dark background.oui/src/themes/oui-next/global_styling/mixins/_form.scss
Lines 265 to 277 in 0365b42
$ouiColorDarkestShade
or$ouiColorDarkShade
are much more suitable for the dark themes input-fields.Screenshots
The text was updated successfully, but these errors were encountered: