Update minimatch to 3.0.8 and 3.1.2 #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Provost <[email protected]>
AMoo-Miki
previously approved these changes
Dec 3, 2022
joshuarrrr
reviewed
Dec 9, 2022
There was a problem hiding this comment.
I'm slightly confused - the package.json indicates we only want to tweak the resolution of @miksu/prettier/minimatch to ^3.0.4. But from the yarn.lock file, all the previous minimatch dependencies already resolved to either 3.0.4 or 3.1.2. After the change, they resolve to either 3.0.8 or 3.1.2. That all makes sense, but it seems a bit misleading to use ^3.0.4 when 3.0.4 is what we want to upgrade. Because it seems like we really don't want to use 3.0.4.
Signed-off-by: Matt Provost <[email protected]>
AMoo-Miki
approved these changes
Dec 9, 2022
joshuarrrr
approved these changes
Dec 9, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 9, 2022
* Update minimatch Signed-off-by: Matt Provost <[email protected]> * Update new version number Signed-off-by: Matt Provost <[email protected]> Signed-off-by: Matt Provost <[email protected]> (cherry picked from commit d593aea)
BSFishy
added a commit
that referenced
this pull request
Dec 14, 2022
* Update minimatch Signed-off-by: Matt Provost <[email protected]> * Update new version number Signed-off-by: Matt Provost <[email protected]> Signed-off-by: Matt Provost <[email protected]> (cherry picked from commit d593aea) Co-authored-by: Matt Provost <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update minimatch to latest patch versions
Check List
yarn lintyarn test-unitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.