Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove calc usage from SchemaItem styles #990

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

AMoo-Miki
Copy link
Collaborator

calc() is not parsed by libsass and shouldn't be used for build-time mathematics.

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • All tests pass
    • yarn lint
    • yarn test-unit
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

@BSFishy BSFishy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is baffling.

@joshuarrrr joshuarrrr merged commit 5fe0b22 into opensearch-project:main Aug 25, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 25, 2023
Signed-off-by: Miki <[email protected]>
(cherry picked from commit 5fe0b22)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
joshuarrrr pushed a commit that referenced this pull request Aug 28, 2023
Signed-off-by: Miki <[email protected]>
(cherry picked from commit 5fe0b22)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@AMoo-Miki AMoo-Miki deleted the remove-bad-calc branch September 27, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants