Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incremented version to 1.3.2. #153

Merged
merged 2 commits into from
May 16, 2022

Conversation

gaiksaya
Copy link
Member

@gaiksaya gaiksaya commented Apr 1, 2022

Coming from opensearch-project/opensearch-build#1805 post release activity.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Sayali Rohidas Gaikawad <[email protected]>
@gaiksaya gaiksaya requested a review from a team April 1, 2022 01:44
@sruti1312
Copy link
Contributor

@gaiksaya Build is failing because of the test-retry dependency version missing. I think it was made unintentionally during replacing 1.3.1 to 1.3.2.

Plugin [id: 'org.gradle.test-retry', version: '1.3.2'] was not found in any of the following sources:

- Gradle Core Plugins (not a core plugin, please see https://docs.gradle.org/6.6.1/userguide/standard_plugins.html for available core plugins)
- Plugin Repositories (could not resolve plugin artifact 'org.gradle.test-retry:org.gradle.test-retry.gradle.plugin:1.3.2')
  Searched in the following repositories:
    Gradle Central Plugin Repository

Signed-off-by: Sayali Gaikawad <[email protected]>
@gaiksaya
Copy link
Member Author

gaiksaya commented Apr 5, 2022

@gaiksaya Build is failing because of the test-retry dependency version missing. I think it was made unintentionally during replacing 1.3.1 to 1.3.2.

Plugin [id: 'org.gradle.test-retry', version: '1.3.2'] was not found in any of the following sources:

- Gradle Core Plugins (not a core plugin, please see https://docs.gradle.org/6.6.1/userguide/standard_plugins.html for available core plugins)
- Plugin Repositories (could not resolve plugin artifact 'org.gradle.test-retry:org.gradle.test-retry.gradle.plugin:1.3.2')
  Searched in the following repositories:
    Gradle Central Plugin Repository

Fixed it. Also I removed the hard corded value for opensearch.version from workflows since default points to 1.3.2-SNAPSHOT

@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2022

Codecov Report

Merging #153 (5fcb1f1) into 1.3 (1b43e2e) will decrease coverage by 0.09%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                1.3     #153      +/-   ##
============================================
- Coverage     72.04%   71.95%   -0.10%     
+ Complexity     2962     2946      -16     
============================================
  Files           376      376              
  Lines         18834    18774      -60     
  Branches       1465     1437      -28     
============================================
- Hits          13569    13508      -61     
+ Misses         4681     4677       -4     
- Partials        584      589       +5     
Impacted Files Coverage Δ
...pensearch/performanceanalyzer/jvm/HeapMetrics.java 40.62% <0.00%> (-15.63%) ⬇️
...performanceanalyzer/rca/framework/api/Symptom.java 90.90% <0.00%> (-9.10%) ⬇️
.../org/opensearch/performanceanalyzer/core/Util.java 62.50% <0.00%> (-8.34%) ⬇️
...formanceanalyzer/PerformanceAnalyzerWebServer.java 68.65% <0.00%> (-5.98%) ⬇️
...anceanalyzer/reader/AdmissionControlProcessor.java 72.09% <0.00%> (-2.33%) ⬇️
...ceanalyzer/reader/MasterMetricsEventProcessor.java 88.88% <0.00%> (-1.86%) ⬇️
.../opensearch/performanceanalyzer/jvm/GCMetrics.java 55.88% <0.00%> (-1.48%) ⬇️
...manceanalyzer/rca/persistence/SQLitePersistor.java 75.30% <0.00%> (-0.93%) ⬇️
...ensearch/performanceanalyzer/hwnet/NetworkE2E.java 80.18% <0.00%> (+2.70%) ⬆️
...nalyzer/rca/net/handler/PublishRequestHandler.java 84.00% <0.00%> (+6.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b43e2e...5fcb1f1. Read the comment docs.

@sruti1312 sruti1312 requested a review from sgup432 May 11, 2022 01:14
@sruti1312 sruti1312 merged commit 6bac1ba into opensearch-project:1.3 May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants