Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update REST resources to follow new OpenSearch naming convention #14

Merged
merged 1 commit into from
May 20, 2021

Conversation

jotok
Copy link
Contributor

@jotok jotok commented May 20, 2021

Plugin resources will appear under /_plugins instead of /_opendistro.

Describe the solution you are proposing
Following the upgrade guide to rename our REST resources.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Plugin resources will appear under /_plugins instead of /_opendistro.
@jotok jotok requested a review from sruti1312 May 20, 2021 06:56
@codecov-commenter
Copy link

Codecov Report

Merging #14 (ca460ff) into main (67d4ab7) will increase coverage by 0.09%.
The diff coverage is 80.76%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #14      +/-   ##
============================================
+ Coverage     72.12%   72.21%   +0.09%     
- Complexity      339      348       +9     
============================================
  Files            43       44       +1     
  Lines          2461     2473      +12     
  Branches        150      155       +5     
============================================
+ Hits           1775     1786      +11     
- Misses          582      584       +2     
+ Partials        104      103       -1     
Impacted Files Coverage Δ Complexity Δ
...ormanceanalyzer/http_action/config/RestConfig.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...on/config/PerformanceAnalyzerResourceProvider.java 36.84% <60.00%> (+0.17%) 9.00 <0.00> (+1.00)
...config/PerformanceAnalyzerClusterConfigAction.java 86.36% <100.00%> (+0.31%) 10.00 <2.00> (+1.00)
...action/config/PerformanceAnalyzerConfigAction.java 92.20% <100.00%> (+0.42%) 24.00 <2.00> (+4.00)
...rformanceAnalyzerOverridesClusterConfigAction.java 80.95% <100.00%> (+0.22%) 18.00 <2.00> (+1.00)
...ormanceanalyzer/writer/EventLogQueueProcessor.java 63.33% <0.00%> (+5.00%) 8.00% <0.00%> (+2.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67d4ab7...ca460ff. Read the comment docs.

@jotok jotok merged commit 0ada819 into main May 20, 2021
public static final String LOGGING_CONFIG_PATH = RestConfig.PA_BASE_URI + "/logging/config";
public static final String BATCH_METRICS_CONFIG_PATH = RestConfig.PA_BASE_URI + "/batch/config";

public static final String LEGACY_RCA_CONFIG_PATH =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These LEGACY_PA_BASE_URI should really be LEGACY_OPENDISTRO_PA_BASE_URI. We weren't super clear in the doc, I fixed it in opensearch-project/opensearch-plugins#33.

@sruti1312 sruti1312 deleted the update-rest-endpoint-names branch June 23, 2021 20:17
@sruti1312 sruti1312 mentioned this pull request Jun 25, 2021
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants