Updates docker download steps to adapt to changes to admin password #2526
Conversation
Signed-off-by: Darshit Chanpura <[email protected]>
DarshitChanpura
requested review from
elfisher,
AMoo-Miki,
nknize,
krisfreedain,
peterzhuamazon,
CEHENKLE,
dtaivpp,
kolchfa-aws and
nateynateynate
as code owners
Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
|
@DarshitChanpura - thanks for this. It looks alright to me, but do we have any tarball installation instructions that might benefit from this information as well? Perhaps we should file a separate issue. https://opensearch.org/docs/2.11/install-and-configure/install-opensearch/tar/ |
These steps will be updated through this PR: opensearch-project/documentation-website#6058 |
Signed-off-by: Darshit Chanpura <[email protected]>
|
@nateynateynate Could I get more reviews on this PR? |
|
@hdhalter @nateynateynate We are planning to release this feature in 2.12. Is there any feedback that needs to be addressed for this PR? If not should this considered as ready to be merged? |
|
@hdhalter @nateynateynate @krisfreedain Would you please review this PR? |
Yes, we can review. @Naarcha-AWS - can you please take a look at this to make sure the changes match the documentation updates? Thanks! |
Signed-off-by: Darshit Chanpura <[email protected]>
|
@Naarcha-AWS would you please re-review this? |
Signed-off-by: Darshit Chanpura <[email protected]>
DarshitChanpura
force-pushed
the
update-docker-setup-steps
branch
from
02160fa to
06503e9
Compare
|
@nateynateynate - is this something you are able to merege? What other approvals does this require? |
|
The link to the documentation page is invalid |
Description
Targeting OpenSearch 2.12.0 and above, the security demo configuration requires a custom password to be passed to setup the demo admin user. To adapt this change in docker distribution, a PR is in flight to modify the sample docker file (opensearch-project/opensearch-build#4274). This PR intends to update the steps to guide user on how to pass this admin password.
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.