Make sure listener is started when query metrics enabled #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Siddhant Deshmukh <[email protected]>
Signed-off-by: Siddhant Deshmukh <[email protected]>
Signed-off-by: Siddhant Deshmukh <[email protected]>
jainankitk
reviewed
Aug 27, 2024
src/main/java/org/opensearch/plugin/insights/core/listener/QueryInsightsListener.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/plugin/insights/core/listener/QueryInsightsListener.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/plugin/insights/core/listener/QueryInsightsListener.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/plugin/insights/core/listener/QueryInsightsListener.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Siddhant Deshmukh <[email protected]>
Signed-off-by: Siddhant Deshmukh <[email protected]>
jainankitk
reviewed
Aug 27, 2024
src/main/java/org/opensearch/plugin/insights/core/listener/QueryInsightsListener.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/plugin/insights/core/listener/QueryInsightsListener.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/plugin/insights/core/listener/QueryInsightsListener.java
Show resolved
Hide resolved
Comment on lines
145
to
151
| if (anyFeatureEnabled && !super.isEnabled()) { | ||
| super.setEnabled(true); | ||
| if (isTopNFeaturePreviouslyDisabled) { | ||
| queryInsightsService.checkAndRestartQueryInsights(); | ||
| } | ||
| queryInsightsService.stop(); | ||
| queryInsightsService.start(); | ||
| } else if (!anyFeatureEnabled && super.isEnabled()) { | ||
| super.setEnabled(false); | ||
| queryInsightsService.stop(); |
There was a problem hiding this comment.
how is the concurrency handled on this stop/start? For example, if 2 features are enabled/disabled in single settings update, how the listeners for respective settings will consume those updated values. Are the listeners executed on cluster service thread?
There was a problem hiding this comment.
AbstractScopedSettings handles makes sure the applySettings method is synchronized
Signed-off-by: Siddhant Deshmukh <[email protected]>
Signed-off-by: Siddhant Deshmukh <[email protected]>
jainankitk
reviewed
Aug 28, 2024
src/test/java/org/opensearch/plugin/insights/core/listener/QueryInsightsListenerTests.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opensearch/plugin/insights/core/listener/QueryInsightsListenerTests.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Siddhant Deshmukh <[email protected]>
jainankitk
approved these changes
Aug 28, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 28, 2024
* Make sure listener is started when query metrics enabled Signed-off-by: Siddhant Deshmukh <[email protected]> * Remove logging Signed-off-by: Siddhant Deshmukh <[email protected]> * Update unit tests Signed-off-by: Siddhant Deshmukh <[email protected]> * Address review comments Signed-off-by: Siddhant Deshmukh <[email protected]> * Refactor enable/disable feature logic Signed-off-by: Siddhant Deshmukh <[email protected]> * Address review comments Signed-off-by: Siddhant Deshmukh <[email protected]> * Remove concurrency not required Signed-off-by: Siddhant Deshmukh <[email protected]> * Remove unnecessary call Signed-off-by: Siddhant Deshmukh <[email protected]> --------- Signed-off-by: Siddhant Deshmukh <[email protected]> (cherry picked from commit 99ccbca) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
deshsidd
pushed a commit
that referenced
this pull request
Aug 28, 2024
dzane17
pushed a commit
to dzane17/query-insights
that referenced
this pull request
Aug 30, 2024
…project#74) * Make sure listener is started when query metrics enabled Signed-off-by: Siddhant Deshmukh <[email protected]> * Remove logging Signed-off-by: Siddhant Deshmukh <[email protected]> * Update unit tests Signed-off-by: Siddhant Deshmukh <[email protected]> * Address review comments Signed-off-by: Siddhant Deshmukh <[email protected]> * Refactor enable/disable feature logic Signed-off-by: Siddhant Deshmukh <[email protected]> * Address review comments Signed-off-by: Siddhant Deshmukh <[email protected]> * Remove concurrency not required Signed-off-by: Siddhant Deshmukh <[email protected]> * Remove unnecessary call Signed-off-by: Siddhant Deshmukh <[email protected]> --------- Signed-off-by: Siddhant Deshmukh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Listener is only started when Top N is enabled. We need to also start the listener when query metrics is enabled.
Also completed some minor refactoring and updating tests.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.