Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude time range check in report details for notebooks reports #116

Closed
wants to merge 1 commit into from

Conversation

davidcui1225
Copy link
Contributor

Signed-off-by: David Cui [email protected]

Description

Exclude checking time range for notebooks report details

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Member

@joshuali925 joshuali925 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a more precise identifier other than notebooks-dashboards string? if not it's fine

@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2021

Codecov Report

Merging #116 (53d183c) into main (c0b29d3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #116   +/-   ##
=========================================
  Coverage     63.40%   63.41%           
  Complexity      309      309           
=========================================
  Files           101      101           
  Lines          4400     4401    +1     
  Branches        668      669    +1     
=========================================
+ Hits           2790     2791    +1     
  Misses         1442     1442           
  Partials        168      168           
Flag Coverage Δ
dashboards-reports 76.01% <100.00%> (+0.01%) ⬆️
reports-scheduler 53.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../components/main/report_details/report_details.tsx 73.73% <100.00%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0b29d3...53d183c. Read the comment docs.

@davidcui1225
Copy link
Contributor Author

is there a more precise identifier other than notebooks-dashboards string? if not it's fine

Yes I'll replace it with checking reportParams.report_source, was in a rush with using the URL check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants