Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport important bug fixes to aos-1.1.0.0 from main #224

Merged

Conversation

zhongnansu
Copy link
Member

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@zhongnansu zhongnansu self-assigned this Nov 9, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2021

Codecov Report

Merging #224 (39e2b90) into aos-1.1.0.0 (e985041) will increase coverage by 0.73%.
The diff coverage is 91.66%.

Impacted file tree graph

@@                Coverage Diff                @@
##             aos-1.1.0.0     #224      +/-   ##
=================================================
+ Coverage          63.39%   64.13%   +0.73%     
  Complexity           309      309              
=================================================
  Files                101      102       +1     
  Lines               4398     4380      -18     
  Branches             669      658      -11     
=================================================
+ Hits                2788     2809      +21     
+ Misses              1442     1403      -39     
  Partials             168      168              
Flag Coverage Δ
dashboards-reports 77.77% <91.66%> (+1.80%) ⬆️
reports-scheduler 53.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ards-reports/public/components/main/main_utils.tsx 76.53% <ø> (ø)
...tsscheduler/action/CreateReportDefinitionAction.kt 66.66% <ø> (ø)
...sscheduler/action/GetAllReportDefinitionsAction.kt 66.66% <ø> (ø)
...rtsscheduler/action/GetAllReportInstancesAction.kt 66.66% <ø> (ø)
...portsscheduler/action/GetReportDefinitionAction.kt 66.66% <ø> (ø)
...reportsscheduler/action/GetReportInstanceAction.kt 66.66% <ø> (ø)
...rtsscheduler/action/InContextReportCreateAction.kt 66.66% <ø> (ø)
...ortsscheduler/action/OnDemandReportCreateAction.kt 66.66% <ø> (ø)
...tsscheduler/action/UpdateReportDefinitionAction.kt 66.66% <ø> (ø)
...heduler/action/UpdateReportInstanceStatusAction.kt 66.66% <ø> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e985041...39e2b90. Read the comment docs.

joshuali925
joshuali925 previously approved these changes Nov 9, 2021
@zhongnansu zhongnansu marked this pull request as draft November 9, 2021 21:02
@zhongnansu zhongnansu marked this pull request as ready for review November 9, 2021 21:52
@zhongnansu
Copy link
Member Author

reports-scheduler CI is failing, local build succeeded. Josh do you have any idea on this failure? @joshuali925

@joshuali925
Copy link
Member

reports-scheduler CI is failing, local build succeeded. Josh do you have any idea on this failure? @joshuali925

try changing this version to -Dopensearch.version=1.1.0? https://github.com/zhongnansu/dashboards-reports/blob/aos-1.1.0.0-szn/.github/workflows/reports-scheduler-test-and-build-workflow.yml#L41

@zhongnansu zhongnansu merged commit ee4bff4 into opensearch-project:aos-1.1.0.0 Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants