Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #281 #289

Closed
wants to merge 1 commit into from
Closed

fix #281 #289

wants to merge 1 commit into from

Conversation

inf17101
Copy link

@inf17101 inf17101 commented Feb 25, 2022

fix #281
changes regex to allow additional customized ids instead of ids in uuid format only.

Description

Better would be /(?:[0-9a-z]+-[0-9a-z]+)+?/ as regex expression because of non-capturing group.
Or to allow only a certain range of characters: /(?:/)([0-9a-z-]{1,100})?/

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

fix opensearch-project#281
changes regex to allow additional customized ids instead of ids in uuid format only.
@inf17101 inf17101 requested a review from a team as a code owner February 25, 2022 10:50
@codecov-commenter
Copy link

Codecov Report

Merging #289 (2c9271e) into main (3b03b70) will increase coverage by 4.41%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #289      +/-   ##
============================================
+ Coverage     72.70%   77.11%   +4.41%     
============================================
  Files            94       30      -64     
  Lines          3924     1866    -2058     
  Branches        608      374     -234     
============================================
- Hits           2853     1439    -1414     
+ Misses          895      424     -471     
+ Partials        176        3     -173     
Flag Coverage Δ
dashboards-reports 77.11% <ø> (ø)
reports-scheduler ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...uler/model/ReportDefinitionDetailsSearchResults.kt
...n/org/opensearch/reportsscheduler/model/RestTag.kt
...pensearch/reportsscheduler/model/ReportInstance.kt
...scheduler/resthandler/OnDemandReportRestHandler.kt
...rtsscheduler/model/InContextReportCreateRequest.kt
...ortsscheduler/model/ReportInstanceSearchResults.kt
...tsscheduler/action/DeleteReportDefinitionAction.kt
...sscheduler/model/UpdateReportDefinitionResponse.kt
...nsearch/reportsscheduler/model/ReportDefinition.kt
...tsscheduler/scheduler/ReportDefinitionJobRunner.kt
... and 54 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b03b70...2c9271e. Read the comment docs.

@zhongnansu zhongnansu self-requested a review March 2, 2022 22:26
Copy link
Member

@zhongnansu zhongnansu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am OK with the change. But for us to merge this PR, you need to do the following

@zhongnansu
Copy link
Member

We want to get this out in 1.3. If the contributor doesn't reply to comments and update PR by March 7th. The team will clost the PR and post another one with correct signature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Imported Dashboards and Visualizations with custom IDs cannot be exported on-demand.
3 participants