Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses custom plugin to publish zips to maven #372

Merged
merged 1 commit into from
Jun 17, 2022

Conversation

joshuali925
Copy link
Member

Signed-off-by: Joshua Li [email protected]

Description

see #351

Issues Resolved

closes #351

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@joshuali925 joshuali925 requested a review from a team as a code owner June 9, 2022 17:26
@joshuali925 joshuali925 self-assigned this Jun 9, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #372 (133fb92) into main (7333102) will increase coverage by 2.51%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #372      +/-   ##
============================================
+ Coverage     74.18%   76.69%   +2.51%     
============================================
  Files            94       30      -64     
  Lines          3966     1905    -2061     
  Branches        639      410     -229     
============================================
- Hits           2942     1461    -1481     
+ Misses          890      441     -449     
+ Partials        134        3     -131     
Flag Coverage Δ
dashboards-reports 76.69% <ø> (ø)
reports-scheduler ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tsscheduler/model/CreateReportDefinitionRequest.kt
...scheduler/model/GetAllReportDefinitionsResponse.kt
...tsscheduler/model/InContextReportCreateResponse.kt
...scheduler/resthandler/OnDemandReportRestHandler.kt
...pensearch/reportsscheduler/model/ReportInstance.kt
...ler/resthandler/ReportDefinitionListRestHandler.kt
.../reportsscheduler/resthandler/PluginBaseHandler.kt
...search/reportsscheduler/security/SecurityAccess.kt
...search/reportsscheduler/action/PluginBaseAction.kt
...ortsscheduler/model/OnDemandReportCreateRequest.kt
... and 54 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7333102...133fb92. Read the comment docs.

@joshuali925 joshuali925 merged commit ca25b88 into opensearch-project:main Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish plugin zips to maven repo
5 participants