-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate reporting frontend plugin to OpenSearch Dashboards #4
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more, but real close.
dashboards-reports/README.md
Outdated
@@ -0,0 +1,70 @@ | |||
# OpenSearch Dashboards Reports for Open Distro |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we leaving "Open Distro" here on purpose?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missed this.. updated
dashboards-reports/README.md
Outdated
|
||
## Setup | ||
|
||
1. Download Elasticsearch for the version that matches the [OpenSearch Dashboards version specified in package.json](./package.json#L7). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Elasticsearch -> OpenSearch?
dashboards-reports/README.md
Outdated
|
||
## Copyright | ||
|
||
Copyright 2020 Amazon.com, Inc. or its affiliates. All Rights Reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2021, like in opensearch-project/OpenSearch@807d0e3
dashboards-reports/THIRD-PARTY
Outdated
* For dashboards-reports see also this required NOTICE: | ||
dashboards-reports | ||
Copyright 2020 Amazon.com, Inc. or its affiliates. All Rights Reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated, thanks
dashboards-reports/server/types.ts
Outdated
@@ -14,6 +14,6 @@ | |||
*/ | |||
|
|||
// eslint-disable-next-line @typescript-eslint/no-empty-interface | |||
export interface OpendistroKibanaReportsPluginSetup {} | |||
export interface OpendistroReportsOpenSearchDashboardsPluginSetup {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More opendistro here and the likes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to ReportsDashboards, thanks
…search-project#4) * Migrate to Opensearch * Rename Kibana in html and md files * WIP rename strings and variables * Rename kibana index * revert kibana_recipients temporarily * Change kbn to osd * Update jest snapshots * Migrate cypress * Change opendistro_kibana_reports to opendistro-reports-opensearch-dashboards * fixup! Migrate to Opensearch * Typo fixes and more renaming * Rename variables in delivery params * Rename kibana user to opensearch dashboards user * Rename Es in variables * Migrate github workflow for dashboards-reports * Move kibana-reports dir to dashboards-reports * Migrate readme * Rename es to opensearch * Remove opendistro in dashboards reports * Update documents for repo * Address comments
…roject#6) * Add necessary files (opensearch-project#4) * Add docs Signed-off-by: Rupal Mahajan <[email protected]> * Update docs to repo name change Signed-off-by: Rupal Mahajan <[email protected]> * Updated MAINTAINERS.md to match recommended opensearch-project format. Signed-off-by: Rupal Mahajan <[email protected]> Signed-off-by: Rupal Mahajan <[email protected]> * Remove chromium related info from readme Signed-off-by: Rupal Mahajan <[email protected]> * nit: remove troubleshooting section Signed-off-by: Rupal Mahajan <[email protected]> * nit: missed font dependencies under troubleshooting Signed-off-by: Rupal Mahajan <[email protected]> Signed-off-by: Rupal Mahajan <[email protected]>
Issue #, if available:
Description of changes:
TODO left:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.