Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jobs building os core in integration test #860

Merged

Conversation

hsiang9431-amzn
Copy link
Contributor

opensearch-project/security-dashboards-plugin pull request intake form

Please provide as much details as possible to get feedback/acceptance on your PR quickly

  1. Category: (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)

  2. Github Issue # or road-map entry, if available:

  3. Description of changes:

  4. Why these changes are required?

  5. What is the old behavior before changes and new behavior after changes? (Please add any example/logs/screen-shot if available)

  6. Testing done: (Please provide details of testing done: Unit testing, integration testing and manual testing)

  7. TO-DOs, if any: (Please describe pending items and provide Github issues# for each of them)

  8. Is it backport from main branch? (If yes, please add backport PR # and commits #)

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@hsiang9431-amzn hsiang9431-amzn changed the title Remove job building os core in integration test Remove jobs building os core in integration test Nov 12, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2021

Codecov Report

Merging #860 (4f28002) into main (6171c72) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #860   +/-   ##
=======================================
  Coverage   71.98%   71.98%           
=======================================
  Files          87       87           
  Lines        1906     1906           
  Branches      247      247           
=======================================
  Hits         1372     1372           
  Misses        480      480           
  Partials       54       54           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6171c72...4f28002. Read the comment docs.

@hsiang9431-amzn hsiang9431-amzn merged commit a48786e into opensearch-project:main Nov 12, 2021
@dblock
Copy link
Member

dblock commented Nov 17, 2021

This still needs to be backported to 1.2 @hsiang9431-amzn.

hsiang9431-amzn added a commit to hsiang9431-amzn/security-dashboards-plugin that referenced this pull request Nov 17, 2021
* Updated copyright notices
(cherry-picked from commit a48786e)

Signed-off-by: Jason <[email protected]>
hsiang9431-amzn added a commit that referenced this pull request Nov 17, 2021
* Updated copyright notices
(cherry-picked from commit a48786e)

Signed-off-by: Jason <[email protected]>
@hsiang9431-amzn hsiang9431-amzn deleted the do-not-build-os-core branch November 17, 2021 19:32
@dblock
Copy link
Member

dblock commented Dec 7, 2021

@hsiang9431-amzn @davidlago was this backported?

@davidlago
Copy link

Yup! #863

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants