Updating backport workflow with custom branch and github app #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vacha Shah <[email protected]>
davidlago
previously approved these changes
Feb 4, 2022
Signed-off-by: Vacha Shah <[email protected]>
VachaShah
changed the title
davidlago
approved these changes
Feb 11, 2022
1 task
|
I am investigating the Unit Test failure in #904 |
peternied
approved these changes
Feb 15, 2022
Codecov Report
@@ Coverage Diff @@
## main #900 +/- ##
=======================================
Coverage 71.98% 71.98%
=======================================
Files 87 87
Lines 1906 1906
Branches 242 242
=======================================
Hits 1372 1372
Misses 480 480
Partials 54 54 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vacha Shah [email protected]
Description
Updating the backport workflow to resolve permissions issue opensearch-project/OpenSearch#1712 and allow custom branch naming for backport branches to manage branch permissions.
Using Github App token in the auto-backport workflow to trigger CI on auto-backport PRs since events created by secrets.GITHUB_TOKEN cannot trigger other workflows. Reference: https://github.community/t/triggering-a-new-workflow-from-another-workflow/16250
Category
Bug fix
Why these changes are required?
Fix permissions issue for the backport workflow.
What is the old behavior before changes and new behavior after changes?
Issues Resolved
[List any issues this PR will resolve (Is this a backport? If so, please add backport PR # and/or commits #)]
Testing
Workflow working in OpenSearch repo, example backport PR opensearch-project/OpenSearch#2079
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.