Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating backport workflow with custom branch and github app #1597

Merged
merged 2 commits into from
Feb 14, 2022

Conversation

VachaShah
Copy link
Contributor

@VachaShah VachaShah commented Feb 4, 2022

Signed-off-by: Vacha Shah [email protected]

Description

Updating the backport workflow to resolve permissions issue opensearch-project/OpenSearch#1712 and allow custom branch naming for backport branches to manage branch permissions.

Using Github App token in the auto-backport workflow to trigger CI on auto-backport PRs since events created by secrets.GITHUB_TOKEN cannot trigger other workflows. Reference: https://github.community/t/triggering-a-new-workflow-from-another-workflow/16250

  • Category BugFix
  • Why these changes are required?
  • What is the old behavior before changes and new behavior after changes?

Issues Resolved

[List any issues this PR will resolve]

Is this a backport? If so, please add backport PR # and/or commits #

Testing

Workflow working in OpenSearch repo, example backport PR opensearch-project/OpenSearch#2079

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@VachaShah VachaShah requested a review from a team February 4, 2022 01:06
@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2022

Codecov Report

Merging #1597 (46b39d1) into main (7ebb2ca) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1597      +/-   ##
============================================
+ Coverage     64.64%   64.70%   +0.06%     
- Complexity     3218     3219       +1     
============================================
  Files           247      247              
  Lines         17351    17351              
  Branches       3082     3082              
============================================
+ Hits          11216    11227      +11     
+ Misses         4585     4574      -11     
  Partials       1550     1550              
Impacted Files Coverage Δ
.../dlic/auth/http/jwt/keybyoidc/KeySetRetriever.java 79.26% <0.00%> (+2.43%) ⬆️
.../auth/http/jwt/keybyoidc/SelfRefreshingKeySet.java 68.30% <0.00%> (+4.92%) ⬆️
...t/keybyoidc/AuthenticatorUnavailableException.java 40.00% <0.00%> (+20.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ebb2ca...46b39d1. Read the comment docs.

davidlago
davidlago previously approved these changes Feb 7, 2022
@VachaShah VachaShah changed the title Updating backport workflow to include custom branch name Updating backport workflow with custom branch and github app Feb 11, 2022
@dblock dblock merged commit 1298a06 into opensearch-project:main Feb 14, 2022
@VachaShah VachaShah deleted the auto-backport branch February 14, 2022 21:49
wuychn pushed a commit to ochprince/security that referenced this pull request Mar 16, 2023
…rch-project#1597)

* Updating backport workflow to include custom branch name

Signed-off-by: Vacha Shah <[email protected]>

* Using Github App to trigger CI on backport PRs

Signed-off-by: Vacha Shah <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants