Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always run the checks on any push or pull request no matter the target #1615

Merged
merged 1 commit into from
Feb 15, 2022

Conversation

peternied
Copy link
Member

Description

Always run the checks on any push or pull request no matter the target.

Following the example from https://github.com/opensearch-project/opensearch-build/blob/bddbc06dd5ee6b67d3be3230cab922a083d4f15a/.github/workflows/python-tests.yml#L4

Issues Resolved

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@peternied peternied requested a review from a team February 15, 2022 18:29
@peternied peternied self-assigned this Feb 15, 2022
@peternied peternied added the bug Something isn't working label Feb 15, 2022
@peternied
Copy link
Member Author

Note; I am not sure there was an issue with the Pull Request vs Push execution. There might be a transient failure that we do not yet have a root cause for, but this should prevent any doubt of altered executions

@DarshitChanpura DarshitChanpura merged commit 755ad1e into opensearch-project:main Feb 15, 2022
@peternied peternied deleted the uniform-ci branch February 15, 2022 19:42
wuychn pushed a commit to ochprince/security that referenced this pull request Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Build] CI and PR checks are behaving differently and have caused a build break on main.
3 participants