Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch gradle to info logging for improved test debugging #1646

Merged
merged 1 commit into from
Feb 28, 2022

Conversation

peternied
Copy link
Member

@peternied peternied commented Feb 25, 2022

Description

Switch gradle to info logging for improved test debugging

Issues Resolved

Testing

  • After the CI checks have passed on this pull request, the logs should increase in size and include the test details. Verified in CI run, 5336510839.

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@peternied peternied requested a review from a team February 25, 2022 16:39
@peternied peternied self-assigned this Feb 25, 2022
@peternied peternied added the enhancement New feature or request label Feb 25, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2022

Codecov Report

Merging #1646 (532fdc4) into main (fc3842c) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1646      +/-   ##
============================================
- Coverage     64.61%   64.57%   -0.05%     
+ Complexity     3217     3214       -3     
============================================
  Files           247      247              
  Lines         17352    17352              
  Branches       3082     3082              
============================================
- Hits          11212    11205       -7     
- Misses         4594     4597       +3     
- Partials       1546     1550       +4     
Impacted Files Coverage Δ
...urity/ssl/transport/SecuritySSLNettyTransport.java 69.14% <0.00%> (-4.26%) ⬇️
...earch/security/ssl/util/SSLConnectionTestUtil.java 93.18% <0.00%> (-2.28%) ⬇️
...a/org/opensearch/security/tools/SecurityAdmin.java 47.59% <0.00%> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc3842c...532fdc4. Read the comment docs.

@@ -50,7 +50,7 @@ jobs:
uses: github/codeql-action/analyze@v1

- name: Test
run: OPENDISTRO_SECURITY_TEST_OPENSSL_OPT=true ./gradlew test
run: OPENDISTRO_SECURITY_TEST_OPENSSL_OPT=true ./gradlew test -i
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this print info level logs on all tests or only failing tests?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This prints logs for everything, which is the behavior when we were using maven

@peternied
Copy link
Member Author

First CI failure was because of the the artifact step, removed in #1645

Fail to upload '/home/runner/work/security/security/build/distributions/opensearch-security-1.3.0.0-securityadmin-standalone.tar.gz' due to 'Blob is incomplete (missing block). Blob: cfb04d1f5f96ec11a5070003ff997c0d, Expected Offset: 0, Actual Offset: 16777216'.
GitHub.Services.Common.VssServiceException: Blob is incomplete (missing block). Blob: cfb04d1f5f96ec11a5070003ff997c0d, Expected Offset: 0, Actual Offset: 16777216
   at GitHub.Services.WebApi.VssHttpClientBase.HandleResponseAsync(HttpResponseMessage response, CancellationToken cancellationToken)
   at GitHub.Services.WebApi.VssHttpClientBase.SendAsync(HttpRequestMessage message, HttpCompletionOption completionOption, Object userState, CancellationToken cancellationToken)
   at GitHub.Services.FileContainer.Client.FileContainerHttpClient.UploadFileAsync(Int64 containerId, String itemPath, Stream fileStream, Byte[] contentId, Int64 fileLength, Boolean isGzipped, Guid scopeIdentifier, CancellationToken cancellationToken, Int32 chunkSize, Int32 chunkRetryTimes, Boolean uploadFirstChunk, Object userState)
   at GitHub.Services.FileContainer.Client.FileContainerHttpClient.UploadFileAsync(Int64 containerId, String itemPath, Stream fileStream, Guid scopeIdentifier, CancellationToken cancellationToken, Int32 chunkSize, Boolean uploadFirstChunk, Object userState, Boolean compressStream)
   at GitHub.Runner.Plugins.Artifact.FileContainerServer.UploadAsync(RunnerActionPluginExecutionContext context, Int32 uploaderId, CancellationToken token)
Associated artifact artifacts (33481726) with run #4523
Error: Critical failure uploading '/home/runner/work/security/security/build/distributions/opensearch-security-1.3.0.0-securityadmin-standalone.zip'
Error: Exit code 1 returned from process: file name '/home/runner/runners/2.2[87](https://github.com/opensearch-project/security/runs/5336510685?check_suite_focus=true#step:11:87).1/bin/Runner.PluginHost', arguments 'action "GitHub.Runner.Plugins.Artifact.PublishArtifact, Runner.Plugins"'.

@peternied peternied merged commit f466069 into opensearch-project:main Feb 28, 2022
@peternied peternied deleted the add-ci-info branch April 21, 2022 19:44
wuychn pushed a commit to ochprince/security that referenced this pull request Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants