Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Placeholder] BWC Tests for DLS/FLS #3054

Conversation

parasjain1
Copy link
Contributor

Description

Updated BWCs and need them to run in GitHub CI actions. This is for the issue mentioned below.

Issues Resolved

#3053

Testing

[Please provide details of testing done: unit testing, integration testing and manual testing]

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@parasjain1 parasjain1 changed the title Placeholder PR for executing BWC Tests in GitHub Actions [Placeholder] BWC Tests for DLS/FLS Jul 26, 2023
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #3054 (4dfdb2c) into main (7f6944c) will increase coverage by 0.21%.
Report is 10 commits behind head on main.
The diff coverage is 77.23%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #3054      +/-   ##
============================================
+ Coverage     64.24%   64.45%   +0.21%     
- Complexity     3491     3534      +43     
============================================
  Files           264      268       +4     
  Lines         20157    20354     +197     
  Branches       3365     3374       +9     
============================================
+ Hits          12949    13119     +170     
- Misses         5527     5541      +14     
- Partials       1681     1694      +13     
Files Coverage Δ
.../main/java/com/amazon/dlic/auth/ldap/LdapUser.java 89.28% <100.00%> (+3.57%) ⬆️
.../opensearch/security/OpenSearchSecurityPlugin.java 84.62% <100.00%> (+0.02%) ⬆️
...earch/security/auditlog/impl/AbstractAuditLog.java 76.59% <100.00%> (+0.10%) ⬆️
...ava/org/opensearch/security/auth/UserInjector.java 90.66% <100.00%> (+0.66%) ⬆️
...org/opensearch/security/filter/SecurityFilter.java 66.19% <100.00%> (+0.32%) ⬆️
.../org/opensearch/security/support/Base64Helper.java 90.90% <100.00%> (+23.63%) ⬆️
...g/opensearch/security/support/ConfigConstants.java 95.00% <ø> (ø)
...rch/security/transport/SecurityRequestHandler.java 55.03% <100.00%> (+0.30%) ⬆️
...c/main/java/org/opensearch/security/user/User.java 71.95% <100.00%> (+15.70%) ⬆️
.../org/opensearch/security/support/HeaderHelper.java 56.25% <50.00%> (-3.75%) ⬇️
... and 7 more

... and 7 files with indirect coverage changes

@parasjain1 parasjain1 force-pushed the parasjaz-custom-serialization-bwc branch 3 times, most recently from e7943a7 to 1bfeb88 Compare July 27, 2023 07:51
@stephen-crawford
Copy link
Contributor

Going to convert this to a draft while debugging is in progress. Thank you for your efforts @parasjain1

@stephen-crawford stephen-crawford marked this pull request as draft July 31, 2023 19:40
@parasjain1 parasjain1 force-pushed the parasjaz-custom-serialization-bwc branch 13 times, most recently from 49b9590 to 91c5734 Compare September 23, 2023 22:26
@parasjain1 parasjain1 force-pushed the parasjaz-custom-serialization-bwc branch 4 times, most recently from 75e1300 to cabe8df Compare September 26, 2023 03:56
@parasjain1 parasjain1 force-pushed the parasjaz-custom-serialization-bwc branch 8 times, most recently from 2720d38 to 513f881 Compare September 28, 2023 06:23
@parasjain1 parasjain1 force-pushed the parasjaz-custom-serialization-bwc branch from 513f881 to 8dbacb7 Compare September 28, 2023 06:42
@parasjain1 parasjain1 force-pushed the parasjaz-custom-serialization-bwc branch from 8dbacb7 to 4dfdb2c Compare September 28, 2023 06:49
@peternied
Copy link
Member

@parasjain1 I'm going to close out this PR since your contribution included these changes - thanks!

@peternied peternied closed this Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants