-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Placeholder] BWC Tests for DLS/FLS #3054
Closed
parasjain1
wants to merge
14
commits into
opensearch-project:main
from
parasjain1:parasjaz-custom-serialization-bwc
Closed
[Placeholder] BWC Tests for DLS/FLS #3054
parasjain1
wants to merge
14
commits into
opensearch-project:main
from
parasjain1:parasjaz-custom-serialization-bwc
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3054 +/- ##
============================================
+ Coverage 64.24% 64.45% +0.21%
- Complexity 3491 3534 +43
============================================
Files 264 268 +4
Lines 20157 20354 +197
Branches 3365 3374 +9
============================================
+ Hits 12949 13119 +170
- Misses 5527 5541 +14
- Partials 1681 1694 +13
|
e7943a7
to
1bfeb88
Compare
Going to convert this to a draft while debugging is in progress. Thank you for your efforts @parasjain1 |
49b9590
to
91c5734
Compare
75e1300
to
cabe8df
Compare
Signed-off-by: Paras Jain <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Paras Jain <[email protected]>
Signed-off-by: Paras Jain <[email protected]>
2720d38
to
513f881
Compare
… nodes Signed-off-by: Paras Jain <[email protected]>
Signed-off-by: Paras Jain <[email protected]>
Signed-off-by: Paras Jain <[email protected]>
513f881
to
8dbacb7
Compare
Signed-off-by: Paras Jain <[email protected]>
8dbacb7
to
4dfdb2c
Compare
@parasjain1 I'm going to close out this PR since your contribution included these changes - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated BWCs and need them to run in GitHub CI actions. This is for the issue mentioned below.
Issues Resolved
#3053
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.