[Cleanup] Remove duplication in Netty4HttpRequestHeaderVerifier #3506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Craig Perkins <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #3506 +/- ##
============================================
- Coverage 65.03% 64.87% -0.16%
+ Complexity 3642 3639 -3
============================================
Files 282 282
Lines 20597 20595 -2
Branches 3390 3388 -2
============================================
- Hits 13395 13361 -34
- Misses 5519 5560 +41
+ Partials 1683 1674 -9
|
Signed-off-by: Craig Perkins <[email protected]>
cwperks
force-pushed
the
header-verifier-cleanup
branch
from
92c94a6 to
2f6019b
Compare
|
@cwperks Should this be marked ready for review? |
peternied
requested changes
Oct 12, 2023
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
cwperks
requested review from
cliu123,
DarshitChanpura,
davidlago,
RyanL1997,
stephen-crawford,
reta and
willyborankin
as code owners
cwperks
commented
Oct 12, 2023
src/main/java/org/opensearch/security/ssl/http/netty/Netty4HttpRequestHeaderVerifier.java
Show resolved
Hide resolved
src/main/java/org/opensearch/security/ssl/http/netty/Netty4HttpRequestHeaderVerifier.java
Show resolved
Hide resolved
src/main/java/org/opensearch/security/ssl/http/netty/Netty4HttpRequestHeaderVerifier.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Craig Perkins <[email protected]>
willyborankin
previously approved these changes
Oct 16, 2023
stephen-crawford
previously approved these changes
Oct 16, 2023
peternied
previously approved these changes
Oct 16, 2023
Signed-off-by: Craig Perkins <[email protected]>
cwperks
dismissed stale reviews from stephen-crawford and willyborankin
via
7ba265c
peternied
approved these changes
Oct 18, 2023
stephen-crawford
approved these changes
Oct 18, 2023
peternied
approved these changes
Oct 18, 2023
DarshitChanpura
approved these changes
Oct 18, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 18, 2023
Removes some duplication in the Netty4HttpRequestHeaderVerifier around the `/_plugins/_security/api/authtoken` endpoint and also abstracts the logic for where authentication is skipped into helper methods. Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit 900d9d5) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
cwperks
pushed a commit
that referenced
this pull request
Oct 18, 2023
…rVerifier (#3564) Backport 900d9d5 from #3506. Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes some duplication in the Netty4HttpRequestHeaderVerifier around the
/_plugins/_security/api/authtokenendpoint and also abstracts the logic for where authentication is skipped into helper methods.Maintenance
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.