Use CODEOWNERS to automate PR review requests #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sujithvm
approved these changes
Apr 8, 2020
|
+1 |
krishna-ggk
referenced
this pull request
in krishna-ggk/security
Apr 21, 2020
(cherry picked from commit bcae5e0)
krishna-ggk
referenced
this pull request
in krishna-ggk/security
Apr 21, 2020
(cherry picked from commit bcae5e0)
krishna-ggk
referenced
this pull request
in krishna-ggk/security
Apr 22, 2020
This reverts commit 3d98d7d.
krishna-ggk
referenced
this pull request
in krishna-ggk/security
Apr 23, 2020
(cherry picked from commit bcae5e0)
krishna-ggk
referenced
this pull request
in krishna-ggk/security
Apr 23, 2020
(cherry picked from commit bcae5e0)
krishna-ggk
referenced
this pull request
in krishna-ggk/security
Apr 23, 2020
(cherry picked from commit bcae5e0)
hardik-k-shah
pushed a commit
that referenced
this pull request
Apr 24, 2020
…odes_dn dynamically (#407) * Use CODEOWNERS to automate PR review requests (#365) (cherry picked from commit bcae5e0) * Migrate dynamic config from listener pattern to publish/subscribe event bus (#364) (cherry picked from commit ef63999) * Fixed CODEOWNERS (#371) (cherry picked from commit 25995ff) * Switch from Guava EventBus to Greenrobot (https://greenrobot.org/eventbus/) EventBus (#370) (cherry picked from commit 96a619c) * Implement APIs and datamodel to configure nodes_dn dynamically. (#362) * Implement APIs and datamodel to configure nodes_dn dynamically. The primary use case is targeted at cross-cluster where in nodes restart can be avoided by populating the coordinating cluster's nodes_dn values to facilitate cross-cluster usecases. **Summary of changes**: - Introduce "nodesdn" datatype to be stored in security index. In a way it is another permission entity similar to internaluser, role etc - Make the above datatype backward compatible i.e do not fail other operations (roles, users etc) - Implement APIs for CRUD operations that are only super-admin accessible and are only enabled based on a YML config value. Co-authored-by: Gopala Krishna Ambareesh <[email protected]> (cherry picked from commit c7b28ad) * Use AuditMessage.Category instead of AuditCategory as per 1.4. (Master is slightly refactored.) * Fix flaky SSL test. Setting "path.home" to non randomized, non-cleanedup directory results in interference from other tests where in the ES state is restored from other run. Co-authored-by: Vlad Rozov <[email protected]>
hardik-k-shah
pushed a commit
that referenced
this pull request
Apr 24, 2020
…des_dn dynamically (#408) * Use CODEOWNERS to automate PR review requests (#365) (cherry picked from commit bcae5e0) * Migrate dynamic config from listener pattern to publish/subscribe event bus (#364) (cherry picked from commit ef63999) Resolved Conflicts: - src/main/java/com/amazon/opendistroforelasticsearch/security/configuration/OpenDistroSecurityIndexSearcherWrapper.java - src/main/java/com/amazon/opendistroforelasticsearch/security/securityconf/DynamicConfigFactory.java * Fixed CODEOWNERS (#371) (cherry picked from commit 25995ff) * Switch from Guava EventBus to Greenrobot (https://greenrobot.org/eventbus/) EventBus (#370) (cherry picked from commit 96a619c) Resolved Conflicts: - src/main/java/com/amazon/opendistroforelasticsearch/security/configuration/OpenDistroSecurityIndexSearcherWrapper.java - src/main/java/com/amazon/opendistroforelasticsearch/security/securityconf/DynamicConfigFactory.java * Implement APIs and datamodel to configure nodes_dn dynamically. (#362) * Implement APIs and datamodel to configure nodes_dn dynamically. The primary use case is targeted at cross-cluster where in nodes restart can be avoided by populating the coordinating cluster's nodes_dn values to facilitate cross-cluster usecases. **Summary of changes**: - Introduce "nodesdn" datatype to be stored in security index. In a way it is another permission entity similar to internaluser, role etc - Make the above datatype backward compatible i.e do not fail other operations (roles, users etc) - Implement APIs for CRUD operations that are only super-admin accessible and are only enabled based on a YML config value. Co-authored-by: Gopala Krishna Ambareesh <[email protected]> (cherry picked from commit c7b28ad) Resolved Conflicts: - src/main/java/com/amazon/opendistroforelasticsearch/security/dlic/rest/api/Endpoint.java * Use AuditMessage.Category instead of AuditCategory as per 1.1 codebase. (Master is slightly refactored.) * Also validate & migrate NodesDn in validate & migrate API calls. * Fix flaky SSL test. Setting "path.home" to non randomized, non-cleanedup directory results in interference from other tests where in the ES state is restored from other run. Co-authored-by: Vlad Rozov <[email protected]>
vrozov
added a commit
that referenced
this pull request
Apr 30, 2020
vrozov
added a commit
that referenced
this pull request
Apr 30, 2020
vrozov
added a commit
that referenced
this pull request
May 1, 2020
lbreinig
pushed a commit
to lbreinig/security
that referenced
this pull request
Dec 23, 2021
wuychn
pushed a commit
to ochprince/security
that referenced
this pull request
Mar 16, 2023
gaobinlong
pushed a commit
to gaobinlong/security
that referenced
this pull request
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Issue #, if available: n/a
*Description of changes: utilize CODEOWNERS
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.