Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Tenants REST API test and partial fix #4166 #4462

Closed

Conversation

willyborankin
Copy link
Collaborator

Description

Added Tenants REST API test

Issues Resolved

partial fix #4166

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

@shikharj05 shikharj05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @willyborankin for fixing this and improving coverage as well :)

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 65.45%. Comparing base (681a944) to head (24fbb53).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4462      +/-   ##
==========================================
+ Coverage   65.43%   65.45%   +0.01%     
==========================================
  Files         312      312              
  Lines       22037    22038       +1     
  Branches     3557     3557              
==========================================
+ Hits        14421    14425       +4     
+ Misses       5843     5840       -3     
  Partials     1773     1773              
Files Coverage Δ
...earch/security/dlic/rest/api/TenantsApiAction.java 38.88% <0.00%> (-2.29%) ⬇️

... and 2 files with indirect coverage changes

@willyborankin willyborankin deleted the refactor-tests#8 branch June 14, 2024 19:00
@willyborankin willyborankin restored the refactor-tests#8 branch June 14, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add posibility to create hidden security entities (roles mapping, roles, etc) via REST API
3 participants