Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update backport section of PR template #4612

Conversation

DarshitChanpura
Copy link
Member

Description

Updates template to notify user to remove backport-failed label from source PR when back-porting it manually

  • Category : Maintenance
  • Why these changes are required?
  • To maintain a clean usage of backport-failed label to allow release-managers to track missing/failed backports correctly.

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…source PR when backporting it manually

Signed-off-by: Darshit Chanpura <[email protected]>
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.27%. Comparing base (bc92a89) to head (75b4b54).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4612      +/-   ##
==========================================
- Coverage   65.28%   65.27%   -0.01%     
==========================================
  Files         317      317              
  Lines       22309    22309              
  Branches     3588     3588              
==========================================
- Hits        14564    14562       -2     
- Misses       5951     5953       +2     
  Partials     1794     1794              

see 3 files with indirect coverage changes

Copy link
Collaborator

@derek-ho derek-ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks DC!

@RyanL1997 RyanL1997 merged commit e73fc24 into opensearch-project:main Aug 6, 2024
43 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 6, 2024
(cherry picked from commit e73fc24)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants