Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Spotless] Applying Google Code Format for core/src/main files #2 #1931

Merged
merged 11 commits into from
Aug 9, 2023
Merged

[Spotless] Applying Google Code Format for core/src/main files #2 #1931

merged 11 commits into from
Aug 9, 2023

Conversation

MitchellGale
Copy link
Contributor

Description

This PR applies Spotless on Java code for:
core/src/main/java/org/opensearch/sql/exception
core/src/main/java/org/opensearch/sql/executor
core/src/main/java/org/opensearch/sql/expression
core/src/main/java/org/opensearch/sql/monitor

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

MitchellGale and others added 6 commits August 2, 2023 14:50
@MitchellGale MitchellGale mentioned this pull request Aug 3, 2023
Merged
6 tasks
@codecov
Copy link

codecov bot commented Aug 3, 2023 •
edited
Loading

Codecov Report

Merging #1931 (4cc4f30) into main (aa88b41) will increase coverage by 0.08%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #1931      +/-   ##
============================================
+ Coverage     97.42%   97.51%   +0.08%     
- Complexity     4646     4658      +12     
============================================
  Files           408      408              
  Lines         11549    11934     +385     
  Branches        838      834       -4     
============================================
+ Hits          11252    11637     +385     
  Misses          290      290              
  Partials          7        7
Flag Coverage Δ
sql-engine 97.51% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...h/sql/exception/ExpressionEvaluationException.java 100.00% <ø> (ø)
...opensearch/sql/exception/QueryEngineException.java 100.00% <ø> (ø)
...ensearch/sql/exception/SemanticCheckException.java 100.00% <ø> (ø)
.../org/opensearch/sql/executor/ExecutionContext.java 100.00% <ø> (ø)
...main/java/org/opensearch/sql/executor/QueryId.java 100.00% <ø> (ø)
...java/org/opensearch/sql/executor/QueryManager.java 100.00% <ø> (ø)
...opensearch/sql/executor/execution/CommandPlan.java 100.00% <ø> (ø)
...opensearch/sql/executor/execution/ExplainPlan.java 100.00% <ø> (ø)
...rch/sql/executor/execution/StreamingQueryPlan.java 100.00% <ø> (ø)
...org/opensearch/sql/executor/pagination/Cursor.java 100.00% <ø> (ø)
... and 69 more

GumpacG
GumpacG previously approved these changes Aug 4, 2023
View reviewed changes
acarbonetto
acarbonetto previously approved these changes Aug 4, 2023
View reviewed changes
Yury-Fridlyand
Yury-Fridlyand previously approved these changes Aug 5, 2023
View reviewed changes
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor polishing is needed

build.gradle Outdated Show resolved Hide resolved
core/src/main/java/org/opensearch/sql/executor/ExecutionEngine.java Outdated Show resolved Hide resolved
core/src/main/java/org/opensearch/sql/executor/QueryManager.java Outdated Show resolved Hide resolved
core/src/main/java/org/opensearch/sql/executor/QueryService.java Outdated Show resolved Hide resolved
core/src/main/java/org/opensearch/sql/executor/pagination/CanPaginateVisitor.java Outdated Show resolved Hide resolved
core/src/main/java/org/opensearch/sql/expression/operator/arthmetic/MathematicalFunction.java Outdated Show resolved Hide resolved
core/src/main/java/org/opensearch/sql/expression/operator/arthmetic/MathematicalFunction.java Outdated Show resolved Hide resolved
core/src/main/java/org/opensearch/sql/expression/operator/arthmetic/MathematicalFunction.java Outdated Show resolved Hide resolved
core/src/main/java/org/opensearch/sql/expression/operator/arthmetic/MathematicalFunction.java Outdated Show resolved Hide resolved
core/src/main/java/org/opensearch/sql/expression/text/TextFunction.java Outdated Show resolved Hide resolved
@MitchellGale
addressed PR comments.
7f85b3b 
Signed-off-by: Mitchell Gale <[email protected]>
@MitchellGale MitchellGale mentioned this pull request Aug 5, 2023
Closed
6 tasks
GumpacG
GumpacG previously approved these changes Aug 8, 2023
View reviewed changes
@MitchellGale MitchellGale mentioned this pull request Aug 8, 2023
Closed
6 tasks
@MitchellGale MitchellGale dismissed stale reviews from Yury-Fridlyand and GumpacG via dc7998a August 9, 2023 17:58
Yury-Fridlyand
Yury-Fridlyand previously approved these changes Aug 9, 2023
View reviewed changes
@MitchellGale
Addressing PR 2 comments.
a69c97a 
Signed-off-by: Mitchell Gale <[email protected]>
GumpacG
GumpacG previously approved these changes Aug 9, 2023
View reviewed changes
Yury-Fridlyand
Yury-Fridlyand reviewed Aug 9, 2023
View reviewed changes
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM, but SL blames some of your recent changes.
Is it possible to export SL output to a file?

@MitchellGale
Ran spotless apply
4cc4f30 
Signed-off-by: Mitchell Gale <[email protected]>
@MitchellGale
Copy link
Contributor Author

LGFM, but SL blames some of your recent changes. Is it possible to export SL output to a file?

Into artifacts?

@MitchellGale
Copy link
Contributor Author

Only failing BWC and codecov. @Yury-Fridlyand @GumpacG now. Good to merge?

@Yury-Fridlyand Yury-Fridlyand merged commit b610ce9 into opensearch-project:main Aug 9, 2023
@Yury-Fridlyand Yury-Fridlyand deleted the integ/sl_GoogleJavaFormat2 branch August 9, 2023 20:03
@MitchellGale MitchellGale mentioned this pull request Aug 9, 2023
Merged
6 tasks
MitchellGale added a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Aug 14, 2023
@MitchellGale
[Spotless] Applying Google Code Format for core/src/main files #2 (op…
d6a7a27 
…ensearch-project#1931)

* Applied spotless changes to `core/stc/main/.../expression` and more.

Signed-off-by: Mitchell Gale <[email protected]>

* Applied all spotless for PR 2 for GJF

Signed-off-by: Mitchell Gale <[email protected]>

* Apply spotless to fix custom fixes.

Signed-off-by: Mitchell Gale <[email protected]>

* Remove unused <br>

Signed-off-by: Mitchell Gale <[email protected]>

* ignoring core checkstyle failures.

Signed-off-by: Mitchell Gale <[email protected]>

* addressed PR comments.

Signed-off-by: Mitchell Gale <[email protected]>

* Addressing PR 2 comments.

Signed-off-by: Mitchell Gale <[email protected]>

* Ran spotless apply

Signed-off-by: Mitchell Gale <[email protected]>

---------

Signed-off-by: Mitchell Gale <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
MitchellGale added a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Aug 18, 2023
@MitchellGale
[Spotless] Applying Google Code Format for core/src/main files #2 (op…
dd86162 
…ensearch-project#1931)

* Applied spotless changes to `core/stc/main/.../expression` and more.

Signed-off-by: Mitchell Gale <[email protected]>

* Applied all spotless for PR 2 for GJF

Signed-off-by: Mitchell Gale <[email protected]>

* Apply spotless to fix custom fixes.

Signed-off-by: Mitchell Gale <[email protected]>

* Remove unused <br>

Signed-off-by: Mitchell Gale <[email protected]>

* ignoring core checkstyle failures.

Signed-off-by: Mitchell Gale <[email protected]>

* addressed PR comments.

Signed-off-by: Mitchell Gale <[email protected]>

* Addressing PR 2 comments.

Signed-off-by: Mitchell Gale <[email protected]>

* Ran spotless apply

Signed-off-by: Mitchell Gale <[email protected]>

---------

Signed-off-by: Mitchell Gale <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
@MitchellGale MitchellGale mentioned this pull request Aug 18, 2023
Merged
6 tasks
Yury-Fridlyand pushed a commit that referenced this pull request Aug 22, 2023
@MitchellGale
[Backport 2.x] [Spotless] Applying Google Code Format for core/src/ma…
df9a827 
…in files #2 #1931 (#1993)

* [Spotless] Applying Google Code Format for core/src/main files #2 (#1931)

* Applied spotless changes to `core/stc/main/.../expression` and more.

Signed-off-by: Mitchell Gale <[email protected]>

* Applied all spotless for PR 2 for GJF

Signed-off-by: Mitchell Gale <[email protected]>

* Apply spotless to fix custom fixes.

Signed-off-by: Mitchell Gale <[email protected]>

* Remove unused <br>

Signed-off-by: Mitchell Gale <[email protected]>

* ignoring core checkstyle failures.

Signed-off-by: Mitchell Gale <[email protected]>

* addressed PR comments.

Signed-off-by: Mitchell Gale <[email protected]>

* Addressing PR 2 comments.

Signed-off-by: Mitchell Gale <[email protected]>

* Ran spotless apply

Signed-off-by: Mitchell Gale <[email protected]>

---------

Signed-off-by: Mitchell Gale <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>

* spotless apply

Signed-off-by: Mitchell Gale <[email protected]>

* address pr comments

Signed-off-by: Mitchell Gale <[email protected]>

---------

Signed-off-by: Mitchell Gale <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GumpacG GumpacG GumpacG approved these changes

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand approved these changes

@acarbonetto acarbonetto acarbonetto left review comments

@pjfitzgibbons pjfitzgibbons Awaiting requested review from pjfitzgibbons

@ps48 ps48 Awaiting requested review from ps48 ps48 is a code owner

@kavithacm kavithacm Awaiting requested review from kavithacm kavithacm is a code owner

@derek-ho derek-ho Awaiting requested review from derek-ho derek-ho is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@dai-chen dai-chen Awaiting requested review from dai-chen dai-chen is a code owner

@YANG-DB YANG-DB Awaiting requested review from YANG-DB YANG-DB is a code owner

@rupal-bq rupal-bq Awaiting requested review from rupal-bq

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@vamsimanohar vamsimanohar Awaiting requested review from vamsimanohar

@Swiddis Swiddis Awaiting requested review from Swiddis Swiddis is a code owner

@penghuo penghuo Awaiting requested review from penghuo penghuo is a code owner

@seankao-az seankao-az Awaiting requested review from seankao-az seankao-az is a code owner

@MaxKsyunz MaxKsyunz Awaiting requested review from MaxKsyunz MaxKsyunz is a code owner

@anirudha anirudha Awaiting requested review from anirudha anirudha is a code owner

@forestmvey forestmvey Awaiting requested review from forestmvey forestmvey is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MitchellGale @GumpacG @Yury-Fridlyand @acarbonetto