Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed week of week based year handling #3299

Merged

Conversation

normanj-bitquill
Copy link
Contributor

@normanj-bitquill normanj-bitquill commented Feb 4, 2025

Description

Updated w formatting for dates to use ISO-8601 behaviour.

Issue: extract(week from <date>) returns the number of weeks in the year based on the DateTimeFormatter which uses 'en' locale.

Expected: extract(week from <date>) returns the number of weeks in the year based on the ISO-1868 week-of-week-based-year.

Related Issues

Resolves #2477

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • New functionality has javadoc added.
  • New functionality has a user manual doc added.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Collaborator

@acarbonetto acarbonetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

Copy link
Collaborator

@penghuo penghuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

@penghuo penghuo merged commit 7d9f6bd into opensearch-project:main Feb 5, 2025
16 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/sql/backport-2.x
# Create a new branch
git switch --create backport/backport-3299-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7d9f6bdeb8e74832065b2db03e5ded98585241eb
# Push it to GitHub
git push --set-upstream origin backport/backport-3299-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-3299-to-2.x.

@acarbonetto acarbonetto deleted the 2477-nj-week-based-years branch February 5, 2025 19:08
normanj-bitquill added a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Feb 5, 2025
Signed-off-by: Norman Jordan <[email protected]>
(cherry picked from commit 7d9f6bd)
acarbonetto pushed a commit that referenced this pull request Feb 5, 2025
Signed-off-by: Norman Jordan <[email protected]>
(cherry picked from commit 7d9f6bd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants