-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Two single or double quote escapes single or double quote when string is surrounded by same type of quote #696
Two single or double quote escapes single or double quote when string is surrounded by same type of quote #696
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
could you add docs to explain the unquote also? |
Signed-off-by: mitchellg <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
… is now expected number. 'I\'m' -> I'm 'I\\''m' -> I\'m 'I\\\'m' -> I\'m Signed-off-by: mitchellg <[email protected]>
Signed-off-by: mitchellg <[email protected]>
Signed-off-by: mitchellg <[email protected]>
…y unquoteText. Signed-off-by: mitchellg <[email protected]>
Signed-off-by: mitchellg <[email protected]>
Signed-off-by: mitchellg <[email protected]>
…der in StringUtilsTest.java Signed-off-by: mitchellg <[email protected]>
…quote. Signed-off-by: mitchellg <[email protected]>
… static and non-static imports Signed-off-by: mitchellg <[email protected]>
Signed-off-by: mitchellg <[email protected]>
Signed-off-by: mitchellg <[email protected]>
Signed-off-by: mitchellg <[email protected]>
… Added case for double, double quote being converted to single, double quote. Signed-off-by: mitchellg <[email protected]>
…gle of their respective type when the string is quoted by the same type. Added some unit tests to test for that condition in StringUtilsTest.java. Signed-off-by: mitchellg <[email protected]>
Signed-off-by: mitchellg <[email protected]>
…gine.java. Signed-off-by: mitchellg <[email protected]>
Signed-off-by: mitchellg <[email protected]>
…gle). Signed-off-by: mitchellg <[email protected]>
Signed-off-by: mitchellg <[email protected]>
Signed-off-by: mitchellg <[email protected]>
…l as double quotes. Signed-off-by: mitchellg <[email protected]>
… StringUtils.java. Signed-off-by: mitchellg <[email protected]>
…rrounded by same string. Consistent with MySQL standard. Signed-off-by: mitchellg <[email protected]>
Signed-off-by: mitchellg <[email protected]>
Signed-off-by: mitchellg <[email protected]>
…rom if statement to break off for a return. Added unit test, removed unit tests for whichquote function. Removed whichquote function. Signed-off-by: mitchellg <[email protected]>
…back tick to skip over String Builder. Fixed issue with strings passed to unquotetext being too small casuing array bounds access issue. Signed-off-by: mitchellg <[email protected]>
Signed-off-by: mitchellg <[email protected]>
Signed-off-by: mitchellg <[email protected]>
Signed-off-by: mitchellg <[email protected]>
Signed-off-by: mitchellg <[email protected]>
Signed-off-by: mitchellg <[email protected]>
f1e018c
to
1a7c927
Compare
… double quote escape implementation. Signed-off-by: mitchellg <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #696 +/- ##
=========================================
Coverage 94.74% 94.75%
- Complexity 2857 2858 +1
=========================================
Files 283 283
Lines 7676 7678 +2
Branches 560 560
=========================================
+ Hits 7273 7275 +2
Misses 349 349
Partials 54 54
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. |
… Integ-DoubleQuote
Please, fix code style:
|
…pensearch-project#696 and 317 all together. (opensearch-project#479) (opensearch-project#481) Signed-off-by: Yury Fridlyand <[email protected]> (cherry picked from commit 646ce3c) Co-authored-by: Yury-Fridlyand <[email protected]>
…pensearch-project#696 and 317 all together. (opensearch-project#479) Signed-off-by: Yury Fridlyand <[email protected]>
* Disable flaky test in JdbcTestIT. (#475) Signed-off-by: penghuo <[email protected]> * Update dependency opensearch-ml-client group name (#477) Signed-off-by: jackieyanghan <[email protected]> * Collected fixes related to bugs #280, #302, #783, #696 and 317 all together. (#479) Signed-off-by: Yury Fridlyand <[email protected]> * Add JDK 8 to CI Matrix (#483) (#484) * fixed references in java 8 and added to ci matrix * filter test that fails due to jdk 8 bug * use different degree to radian conversion for difference in jdk * skip date time format tests that cause error due to jdk bug * only disable DateTime unit test on Java 8 Bypassing failed DCO check Signed-off-by: David Cui <[email protected]> (cherry picked from commit b6fccbd) Co-authored-by: David Cui <[email protected]> * Add parse docs to PPL commands index (#486) (#487) Signed-off-by: Joshua Li <[email protected]> * Add 1.3.0 release notes (#492) Signed-off-by: Eugene Lee <[email protected]> * Add Kmeans and AD command documentation (#493) (#497) Signed-off-by: jackieyanghan <[email protected]> (cherry picked from commit ee4bce0) * Bump version to 1.3.1 Signed-off-by: Sayali Gaikawad <[email protected]> * Bump ml Signed-off-by: Sayali Gaikawad <[email protected]> * Add new zip Signed-off-by: Sayali Gaikawad <[email protected]> * Updated release drafter Signed-off-by: Sayali Gaikawad <[email protected]> * Remove checked-in ml-commons dependency (#529) Signed-off-by: jackieyanghan <[email protected]> * Bump workbench to 1.3.1 (#540) Signed-off-by: Joshua Li <[email protected]> * Bug Fix, return default ID when log4j ThreadContext is empty (#538) (#539) (#543) Signed-off-by: penghuo <[email protected]> (cherry picked from commit 54b7257) * Incremented version to 1.3.2. (#593) Signed-off-by: Zelin Hao <[email protected]> Signed-off-by: Joshua Li <[email protected]> Co-authored-by: Joshua Li <[email protected]> * Version bump 1.3.3 Signed-off-by: pgodithi <[email protected]> * [1.3] Bump spring-beans to 5.2.20 (#632) Signed-off-by: Joshua Li <[email protected]> * Version bump 1.3.3 Signed-off-by: pgodithi <[email protected]> * Incremented version to 1.3.4. (#681) * Incremented version to 1.3.4. Signed-off-by: Zelin Hao <[email protected]> * bump jackson to 2.13.2 Signed-off-by: Joshua Li <[email protected]> Co-authored-by: Joshua Li <[email protected]> Co-authored-by: Peng Huo <[email protected]> Co-authored-by: Jackie Han <[email protected]> Co-authored-by: Yury-Fridlyand <[email protected]> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: David Cui <[email protected]> Co-authored-by: Eugene Lee <[email protected]> Co-authored-by: Sayali Gaikawad <[email protected]> Co-authored-by: Sayali Gaikawad <[email protected]> Co-authored-by: Joshua Li <[email protected]> Co-authored-by: Zelin Hao <[email protected]> Co-authored-by: pgodithi <[email protected]> Co-authored-by: Anirudha (Ani) Jadhav <[email protected]>
Signed-off-by: mitchellg <[email protected]>
+1. Probably can add here: https://github.com/opensearch-project/sql/blob/main/docs/user/general/datatypes.rst#string-data-types |
… is surrounded by same type of quote (opensearch-project#696) Signed-off-by: MitchellGale-BitQuill <[email protected]>
…pensearch-project#696 and 317 all together. Signed-off-by: Yury Fridlyand <[email protected]>
Description
Adds implementation for double quotes working to escape a single quote.
Uses string builder to generate query in
String Utils
. Only escapes quote when outside quotes are matching, does not work for `. Below are examples of how the new queries function.Issues Resolved
[Issue #682]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.