-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.1] Staging for version increment automation #706
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.1 #706 +/- ##
=============================================
- Coverage 94.67% 62.76% -31.92%
=============================================
Files 280 10 -270
Lines 7570 658 -6912
Branches 558 118 -440
=============================================
- Hits 7167 413 -6754
+ Misses 349 192 -157
+ Partials 54 53 -1
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. |
Hey @joshuali925 , @penghuo can you please check this backport PR? |
approved. also DCO failed, your name in sign-off message doesn't match github profile name |
Hey @joshuali925 |
@prudhvigodithi DCO checks git author not committer, i'm just pointing out that your sign-off message is inconsistent. I don't think we can fix it for this PR, but you might want to fix it so it passes for future backport PRs. This is the commit by
|
* Version increment automation Signed-off-by: pgodithi <[email protected]> (cherry picked from commit 69ab0d3) Signed-off-by: prudhvigodithi <[email protected]>
54cffc0
to
80f9ce9
Compare
Hey @joshuali925 I have fixed the DCO, please check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, although DCO will still fail if it runs on pushes to 2.1 branch, or this PR gets backported again. Please sign off using Prudhvi Godithi
instead of pgodithi
or prudhvigodithi
(another option is to change your GitHub name). It's ok for this PR, i'm just trying to avoid DCO failing for future PRs
…ensearch-project#706). Signed-off-by: currantw <[email protected]>
…ensearch-project#706). Signed-off-by: currantw <[email protected]>
Backport 69ab0d3 from #684