Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.1] Staging for version increment automation #706

Merged
merged 1 commit into from
Aug 16, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 69ab0d3 from #684

@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner July 21, 2022 20:10
@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2022

Codecov Report

Merging #706 (54cffc0) into 2.1 (fc476e5) will decrease coverage by 31.91%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##                2.1     #706       +/-   ##
=============================================
- Coverage     94.67%   62.76%   -31.92%     
=============================================
  Files           280       10      -270     
  Lines          7570      658     -6912     
  Branches        558      118      -440     
=============================================
- Hits           7167      413     -6754     
+ Misses          349      192      -157     
+ Partials         54       53        -1     
Flag Coverage Δ
query-workbench 62.76% <ø> (ø)
sql-engine ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rg/opensearch/sql/data/model/ExprBooleanValue.java
...ch/sql/opensearch/planner/physical/ADOperator.java
...rch/planner/logical/rule/MergeAggAndIndexScan.java
...protocol/response/format/CsvResponseFormatter.java
...l/expression/window/ranking/RowNumberFunction.java
...pensearch/sql/planner/physical/RemoveOperator.java
...sql/expression/aggregation/AggregatorFunction.java
.../opensearch/sql/protocol/response/QueryResult.java
...on/operator/predicate/BinaryPredicateOperator.java
...ch/storage/script/filter/lucene/WildcardQuery.java
... and 260 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

@prudhvigodithi
Copy link
Member

prudhvigodithi commented Jul 25, 2022

Hey @joshuali925 , @penghuo can you please check this backport PR?
@bbarani

joshuali925
joshuali925 previously approved these changes Jul 25, 2022
@joshuali925
Copy link
Member

approved. also DCO failed, your name in sign-off message doesn't match github profile name

@prudhvigodithi
Copy link
Member

prudhvigodithi commented Jul 25, 2022

approved. also DCO failed, your name in sign-off message doesn't match github profile name

Hey @joshuali925
This believe this is trigged from the opensearch-trigger-bot user, so you say some DCO failure with bot user commit ?
Thank you

@joshuali925
Copy link
Member

@prudhvigodithi DCO checks git author not committer, i'm just pointing out that your sign-off message is inconsistent. I don't think we can fix it for this PR, but you might want to fix it so it passes for future backport PRs. This is the commit by opensearch-trigger-bot, notice Author says Prudhvi Godithi but commit message says Signed-off-by: pgodithi

* commit 54cffc025f7eee20a4f271983b9e52ec84228415 (HEAD -> pr/706, origin/backport/backport-684-to-2.1)
| Author:     Prudhvi Godithi <[email protected]>
| AuthorDate: Thu Jul 21 16:09:59 2022 -0400
| Commit:     github-actions[bot] <github-actions[bot]@users.noreply.github.com>
| CommitDate: Thu Jul 21 20:10:21 2022 +0000
|
|     Staging for version increment automation (#684)
|
|     * Version increment automation
|     Signed-off-by: pgodithi <[email protected]>
|     (cherry picked from commit 69ab0d33c8d273fb0df9bf3c52ddd48a58093b01)
Error: The SoB (DCO) check failed

  [5](https://github.com/opensearch-project/sql/runs/7457143683?check_suite_focus=true#step:3:6)4cffc025f7eee20a4f271983b9e52ec84228415    Expected "Prudhvi Godithi <[email protected]>", but got "pgodithi <[email protected]>".

* Version increment automation
Signed-off-by: pgodithi <[email protected]>
(cherry picked from commit 69ab0d3)
Signed-off-by: prudhvigodithi <[email protected]>
@prudhvigodithi
Copy link
Member

Hey @joshuali925 I have fixed the DCO, please check.
Thank you

Copy link
Member

@joshuali925 joshuali925 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, although DCO will still fail if it runs on pushes to 2.1 branch, or this PR gets backported again. Please sign off using Prudhvi Godithi instead of pgodithi or prudhvigodithi (another option is to change your GitHub name). It's ok for this PR, i'm just trying to avoid DCO failing for future PRs

@joshuali925 joshuali925 merged commit cc79a4a into 2.1 Aug 16, 2022
@github-actions github-actions bot deleted the backport/backport-684-to-2.1 branch August 16, 2022 23:04
currantw added a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Oct 30, 2024
currantw added a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants