Skip to content

Commit

Permalink
Use HTTP2MatchHeaderFieldSendSettings for incoming gRPC connections
Browse files Browse the repository at this point in the history
gRPC clients which wait until they receive a `SETTINGS` frame may not be
able to connect to CRI-O because of a limitation to cmux:
- https://github.com/soheilhy/cmux#limitations

The issue seems not yet solved and causes impossible connection when
upgrading cri-tools to the latest version of gRPC. A possible workaround
is to export the environment variable: `GRPC_GO_REQUIRE_HANDSHAKE=off`.

Reference: grpc/grpc-go#2636

Signed-off-by: Sascha Grunert <[email protected]>
  • Loading branch information
saschagrunert authored and openshift-cherrypick-robot committed Sep 5, 2019
1 parent ed8e23b commit cb2f4ae
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion cmd/crio/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -632,7 +632,7 @@ func main() {
}

m := cmux.New(lis)
grpcL := m.Match(cmux.HTTP2HeaderField("content-type", "application/grpc"))
grpcL := m.MatchWithWriters(cmux.HTTP2MatchHeaderFieldSendSettings("content-type", "application/grpc"))
httpL := m.Match(cmux.HTTP1Fast())

infoMux := service.GetInfoMux()
Expand Down

0 comments on commit cb2f4ae

Please sign in to comment.