cleanup: remove duplicated logs and requeue with error #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains following cleanups :
reconcile
functionreturn ctrl.Result{Requeue: true}, err
as it is equivalent toreturn ctrl.Result{}, err
, which will trigger another reconcile for the same CR ( and also log the error ). See https://github.com/kubernetes-sigs/controller-runtime/blob/75a38d2123d4696d24d8d3c6b2966e7a34442653/pkg/reconcile/reconcile.go#L93-L103