-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workflow to release midstream plugin #10
Workflow to release midstream plugin #10
Conversation
Signed-off-by: Ali Ok <[email protected]> (cherry picked from commit 918c58f)
Signed-off-by: Ali Ok <[email protected]>
Skipping CI for Draft Pull Request. |
Signed-off-by: Ali Ok <[email protected]>
Signed-off-by: Ali Ok <[email protected]>
DATE_TIME=$(date +"%Y%m%d%H%M%S") | ||
RELEASE_NAME="${BASE_RELEASE_VERSION}.0-${DATE_TIME}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we append the short commit sha instead of the datetime?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think commit hash alone is not good, but I can add it to the end like release-1.2.3-202401010101-deadbeef
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is not good?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also the -
is an indicator of pre-releases, I think what we want is the build identifier with a +
, eg 1.33.0+<buid-id>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also wondering if we should increment the patch version versus pre-releases or build numbers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can also list versions and figure out what's the "next patch for a major.minor" ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, all commits in a release branch would cause a new package being published.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BASE_RELEASE_NAME="0.1"; npm view @knative-extensions/plugin-knative-event-mesh-backend versions --json | grep ${BASE_RELEASE_NAME} | tail -1 | tr -d '"' | awk -F \. '{print $3+1}'
This will give us the next patch version for @knative-extensions/plugin-knative-event-mesh-backend
package, which is 3
, given the BASE_RELEASE_NAME
being 0.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, what can go wrong, right? :D Let me incorporate this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot can go wrong :) but I think it's a little better
for sure we need to add the concurrency https://docs.github.com/en/actions/using-jobs/using-concurrency as a follow up
Signed-off-by: Ali Ok <[email protected]>
Signed-off-by: Ali Ok <[email protected]>
Signed-off-by: Ali Ok <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aliok, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test all |
0255e5b
into
openshift-knative:release-v1.12
Pipeline failed https://github.com/openshift-knative/backstage-plugins/actions/runs/9018345667/job/24778750006
|
Sorry, my bad. This wasn't ready! I wrote you in private that I will test stuff locally before merging, but didn't add a hold. Reverting now. |
Tested here: https://github.com/aliok/backstage-plugins-no-fork-test/