Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test GH actions gate keeping #8

Closed
wants to merge 6 commits into from
Closed

Test GH actions gate keeping #8

wants to merge 6 commits into from

Conversation

aliok
Copy link

@aliok aliok commented Apr 4, 2024

  • Test GH actions gate keeping

Signed-off-by: Ali Ok [email protected]

  • Test GH actions gate keeping

Signed-off-by: Ali Ok [email protected]

Signed-off-by: Ali Ok [email protected]
(cherry picked from commit 9003a76)

@aliok
Test GH actions gate keeping (knative-extensions#6)
ed7b885 
* Test GH actions gate keeping

Signed-off-by: Ali Ok <[email protected]>

* Test GH actions gate keeping

Signed-off-by: Ali Ok <[email protected]>

---------

Signed-off-by: Ali Ok <[email protected]>
(cherry picked from commit 9003a76)
@openshift-ci openshift-ci bot requested review from matzew and pierDipi April 4, 2024 08:30
@openshift-ci openshift-ci bot added the approved label Apr 4, 2024
pierDipi
pierDipi approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Apr 4, 2024
@aliok
Copy link
Author

aliok commented Apr 4, 2024

Screenshot 2024-04-04 at 11 47 38

Gatekeeping works. I messed up a test on purpose: c497e58

@openshift-ci openshift-ci bot removed the lgtm label Apr 4, 2024
@pierDipi
Copy link
Member

pierDipi commented Apr 4, 2024 •
edited
Loading

@aliok to actually test it we need to wait for ci/prow/415-images to complete while Backstage unit tests / Test fails and the PR is approved and lgtm'd

pierDipi
pierDipi approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Apr 4, 2024
@pierDipi
Copy link
Member

pierDipi commented Apr 4, 2024

/test ?

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 4, 2024

@pierDipi: The following commands are available to trigger required jobs:

  • /test 412-images
  • /test 415-images
  • /test 416-images

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-knative-backstage-plugins-release-v1.12-415-images

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierDipi
Copy link
Member

pierDipi commented Apr 4, 2024

/test pull-ci-openshift-knative-backstage-plugins-release-v1.12-415-images

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 4, 2024

@pierDipi: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test 412-images
  • /test 415-images
  • /test 416-images

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-knative-backstage-plugins-release-v1.12-415-images

In response to this:

/test pull-ci-openshift-knative-backstage-plugins-release-v1.12-415-images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierDipi
Copy link
Member

pierDipi commented Apr 4, 2024

/test all

@openshift-ci openshift-ci bot removed the lgtm label Apr 5, 2024
pierDipi
pierDipi approved these changes Apr 5, 2024
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Apr 5, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aliok aliok mentioned this pull request Apr 5, 2024
Merged
@aliok
Copy link
Author

aliok commented Apr 5, 2024

Created openshift/release#50622 for auto merge

@aliok
Copy link
Author

aliok commented Apr 5, 2024

/close

@aliok aliok closed this Apr 5, 2024
@aliok aliok reopened this Apr 5, 2024
@openshift-ci openshift-ci bot closed this Apr 5, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 5, 2024

@aliok: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aliok aliok reopened this Apr 5, 2024
@aliok aliok closed this Apr 5, 2024
@aliok aliok mentioned this pull request Apr 5, 2024
Merged
@aliok aliok changed the title Test GH actions gate keeping (#6) Test GH actions gate keeping Apr 5, 2024
@aliok aliok deleted the 2024-04-04-gh-actions-for-unit-tests-openshift-112 branch April 24, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierDipi pierDipi pierDipi approved these changes

@matzew matzew Awaiting requested review from matzew

Assignees

@pierDipi pierDipi

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aliok @pierDipi