[release-v1.11]Adding the magic cert injection and patch file for it #437
Conversation
matzew
force-pushed
the
config-trusted-cabundle
branch
from
7b729c8 to
3cef736
Compare
|
/test 411-test-reconciler-aws-ocp-411 |
matzew
changed the title
There was a problem hiding this comment.
This new file will be reconciled and applied but also modified by OCP, will that cause our controller to constantly re-update it?
There was a problem hiding this comment.
wouldn't just update fields that are present?
There was a problem hiding this comment.
I don't know that's why I'm asking (as this assumption caused issues in the past and that's why we remove the "namespace" from the resources openshift-knative/serverless-operator#1714)
There was a problem hiding this comment.
No, that cm is not constantly updated.
|
/test 411-test-reconciler-aws-ocp-411 |
…t. This allows us to mount in custom ca bundles via ConfigMap/VolumeSource. OCP documentation is here: https://docs.openshift.com/container-platform/4.14/networking/configuring-a-custom-pki.html#certificate-injection-using-operators_configuring-a-custom-pki Signed-off-by: Matthias Wessendorf <[email protected]>
matzew
force-pushed
the
config-trusted-cabundle
branch
from
3cef736 to
e461d2d
Compare
|
@pierDipi I relocated the CM to the When we merge this, we avoid patching the same on the operator level. |
|
/test 413-test-reconciler-aws-ocp-413 |
2 similar comments
|
/test 413-test-reconciler-aws-ocp-413 |
|
/test 413-test-reconciler-aws-ocp-413 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-v1.12 |
|
@matzew: new pull request created: #443 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…patch and apply) was here: openshift-knative#437) Signed-off-by: Matthias Wessendorf <[email protected]>
…patch and apply) was here: #437) (#454) Signed-off-by: Matthias Wessendorf <[email protected]>
…patch and apply) was here: openshift-knative#437) (knative#454) Signed-off-by: Matthias Wessendorf <[email protected]>
JIRA: #SRVKE-1546
Adding a
ConfigMapfor OCP that does "Certificate injection":Doc for the injection
https://docs.openshift.com/container-platform/4.14/networking/configuring-a-custom-pki.html#certificate-injection-using-operators_configuring-a-custom-pki