-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-17037: Fix upgrade failure due to immutable label selectors #649
OCPBUGS-17037: Fix upgrade failure due to immutable label selectors #649
Conversation
@fontivan: This pull request references Jira Issue OCPBUGS-17037, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jc-rh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@fontivan: Jira Issue OCPBUGS-17037: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-17037 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-4.13 |
@fontivan: new pull request created: #650 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-4.12 |
@fontivan: new pull request created: #651 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This fixes upgrade due to immutable selector labels by adding a -v2 suffix to the controller manager deployment.
This is the intended solution for when you need to make changes to an immutable field as per OLM: operator-framework/operator-lifecycle-manager#952 (comment)
If we need to make another immutable change in the future then we can just increment v2 to v3 and so on.