Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-17037: Fix upgrade failure due to immutable label selectors #649

Conversation

fontivan
Copy link
Collaborator

This fixes upgrade due to immutable selector labels by adding a -v2 suffix to the controller manager deployment.

This is the intended solution for when you need to make changes to an immutable field as per OLM: operator-framework/operator-lifecycle-manager#952 (comment)

If we need to make another immutable change in the future then we can just increment v2 to v3 and so on.

@openshift-ci-robot
Copy link

@fontivan: This pull request references Jira Issue OCPBUGS-17037, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This fixes upgrade due to immutable selector labels by adding a -v2 suffix to the controller manager deployment.

This is the intended solution for when you need to make changes to an immutable field as per OLM: operator-framework/operator-lifecycle-manager#952 (comment)

If we need to make another immutable change in the future then we can just increment v2 to v3 and so on.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from fedepaol and jc-rh August 23, 2023 16:53
@fontivan
Copy link
Collaborator Author

Screenshot from 2023-08-23 12-46-36
Screenshot from 2023-08-23 12-47-13
Screenshot from 2023-08-23 12-47-19

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2023
@openshift-ci
Copy link

openshift-ci bot commented Aug 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jc-rh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2023
@openshift-merge-robot openshift-merge-robot merged commit cf5d377 into openshift-kni:main Aug 23, 2023
@openshift-ci-robot
Copy link

@fontivan: Jira Issue OCPBUGS-17037: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-17037 has been moved to the MODIFIED state.

In response to this:

This fixes upgrade due to immutable selector labels by adding a -v2 suffix to the controller manager deployment.

This is the intended solution for when you need to make changes to an immutable field as per OLM: operator-framework/operator-lifecycle-manager#952 (comment)

If we need to make another immutable change in the future then we can just increment v2 to v3 and so on.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fontivan
Copy link
Collaborator Author

/cherry-pick release-4.13

@openshift-cherrypick-robot

@fontivan: new pull request created: #650

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fontivan
Copy link
Collaborator Author

/cherry-pick release-4.12

@openshift-cherrypick-robot

@fontivan: new pull request created: #651

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants