-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the beta by default in OpenShift Pipelines #632
Conversation
/test pipeline-service-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
fingers crossed (seems likely) this addresses redhat-appstudio/infra-deployments#1776 (comment)
@Michkov FYI
/test pipeline-service-test |
I can see the following error in the operator's pod logs:
I thought I followed [the doc|https://tekton.dev/docs/pipelines/additional-configs/#beta-features]. Looking into the problem. |
Let's be careful about what "beta" means here - @vdemeester I think this might be a source of confusion for teams migrating to the v1 API. I don't think this means "enable the v1beta1 API" - that is still there and isn't going away. That API version, however, might have breaking changes from 1.9 to 1.10... |
/test pipeline-service-test |
I didn't really understand everything, but this value is coming from upstream tektoncd/pipeline, and it is indeed confusing, see tektoncd/pipeline#6592 (comment). It definitely doesn't mean "enable the v1beta1 API" indeed, and needs to be refined. But, as pointed out in the comment, having it to stable comes with a very very very confusing behavior when migrating things from v1beta1 to v1. This change will need a 1.9.3 or 1.10.1 to be released before being successful 😅 |
/retest |
No description provided.