-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-48740: Add missing CSP directives #2164
base: release-4.18
Are you sure you want to change the base?
Conversation
@jhadvig: This pull request references Jira Issue OCPBUGS-48740, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Hello @jhadvig! Some important instructions when contributing to openshift/api: |
Have the 4.19 changes hit the payload yet? Can we make sure that the 4.19 bug is verified before we move forward here please |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jhadvig The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@JoelSpeed yes, both PR should be already part of the payload. spinning a 4.19 techpreview cluster for confirmation. |
@jhadvig: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Hmm, although the both PRs are merged in the master, I dont see the added |
Has the operator had its deps bumped to include the latest version of o/api? |
Manual backport of #2163
/assign @spadgett @JoelSpeed