Improving documentation around new image tags, cleanup old Operator-SDK logic #247
Conversation
| MAINPACKAGE = ./cmd/manager | ||
| API_DIR = ./pkg/apis | ||
| endif | ||
| API_DIR = ./api |
There was a problem hiding this comment.
Or just inline it. Is it used anywhere else?
There was a problem hiding this comment.
All three of these, actually.
Unless they're overridden in consuming projects?
There was a problem hiding this comment.
They shouldn't be overridden since we should all have the same structure, so +1
Signed-off-by: Michael Shen <[email protected]>
Signed-off-by: Michael Shen <[email protected]>
|
@mjlshen: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 2uasimojo, mjlshen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
OSD-13437: Continuing cleanup work as a result of #246 before releasing a v3.0.1
golang-osd-operatorconventionALLOW_DIRTY_CHECKOUTworkaround in the error message ofmake iscleanGOEXPERIMENT=boringcryptoall: move dev.boringcrypto into main branch behind GOEXPERIMENT golang/go#51940 (comment)