-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.11] OCPBUGS-9908: Garbage collect grafana-dashboard-etcd #1022
[release-4.11] OCPBUGS-9908: Garbage collect grafana-dashboard-etcd #1022
Conversation
@Elbehery: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@Elbehery: This pull request references Jira Issue OCPBUGS-9908, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
2109424
to
dcea5e2
Compare
/assign @dusk125 |
/lgtm |
/assign @wking |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dusk125, Elbehery, tjungblu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @geliu2016 |
/label cherry-pick-approved |
/cherry-pick release-4.10 |
@tjungblu: once the present PR merges, I will cherry-pick it on top of release-4.10 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/jira refresh |
@tjungblu: This pull request references Jira Issue OCPBUGS-9908, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
actually, we might not need this in 4.10, correct? |
No, I think only till 4.11 iiuc cc @wking |
@Elbehery: once the present PR merges, I will cherry-pick it on top of cancel in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
i tried |
/jira refresh |
@Elbehery: This pull request references Jira Issue OCPBUGS-9908, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/jira refresh |
@Elbehery: This pull request references Jira Issue OCPBUGS-9908, which is valid. The bug has been moved to the POST state. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@geliu2016 can you label this & verify please ? |
/test e2e-operator |
1 similar comment
/test e2e-operator |
/retest-required |
@Elbehery: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@Elbehery: Jira Issue OCPBUGS-9908: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-9908 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@tjungblu: #1022 failed to apply on top of branch "release-4.10":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@geliu2016 can we verify this as well ? Please ignore |
this is a manual cherrypick of #1016
resolves https://issues.redhat.com/browse/OCPBUGS-9908