Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.11] OCPBUGS-9908: Garbage collect grafana-dashboard-etcd #1022

Conversation

Elbehery
Copy link
Contributor

@Elbehery Elbehery commented Mar 9, 2023

this is a manual cherrypick of #1016

resolves https://issues.redhat.com/browse/OCPBUGS-9908

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 9, 2023

@Elbehery: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.11] OCPBUGS-9908: Garbage collect grafana-dashboard-etcd

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 9, 2023
@openshift-ci-robot
Copy link

@Elbehery: This pull request references Jira Issue OCPBUGS-9908, which is invalid:

  • expected dependent Jira Issue OCPBUGS-8393 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is ASSIGNED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

this is a manual cherrypick of #1016

resolves https://issues.redhat.com/browse/OCPBUGS-9908

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from hasbro17 and tjungblu March 9, 2023 10:18
@Elbehery Elbehery force-pushed the cherrypick-garbage-collect-grafana-dashboard branch from 2109424 to dcea5e2 Compare March 9, 2023 10:19
@Elbehery
Copy link
Contributor Author

Elbehery commented Mar 9, 2023

/assign @dusk125

@tjungblu
Copy link
Contributor

tjungblu commented Mar 9, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 9, 2023
@Elbehery
Copy link
Contributor Author

Elbehery commented Mar 9, 2023

/assign @wking

@dusk125
Copy link
Contributor

dusk125 commented Mar 9, 2023

/approve
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Mar 9, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dusk125, Elbehery, tjungblu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2023
@Elbehery
Copy link
Contributor Author

Elbehery commented Mar 9, 2023

/assign @geliu2016

@geliu2016
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 10, 2023
@tjungblu
Copy link
Contributor

/cherry-pick release-4.10

@openshift-cherrypick-robot

@tjungblu: once the present PR merges, I will cherry-pick it on top of release-4.10 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tjungblu
Copy link
Contributor

/jira refresh

@openshift-ci-robot
Copy link

@tjungblu: This pull request references Jira Issue OCPBUGS-9908, which is invalid:

  • expected dependent Jira Issue OCPBUGS-8393 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tjungblu
Copy link
Contributor

actually, we might not need this in 4.10, correct?

@Elbehery
Copy link
Contributor Author

actually, we might not need this in 4.10, correct?

No, I think only till 4.11 iiuc

cc @wking

@openshift-cherrypick-robot

@Elbehery: once the present PR merges, I will cherry-pick it on top of cancel in a new PR and assign it to you.

In response to this:

/cherry-pick cancel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Elbehery
Copy link
Contributor Author

/cherry-pick release-4.10

i tried /cherry-pick cancel but it is wrong :D .. how to cancel this ?

@Elbehery
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link

@Elbehery: This pull request references Jira Issue OCPBUGS-9908, which is invalid:

  • expected dependent Jira Issue OCPBUGS-8393 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Elbehery
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Mar 17, 2023
@openshift-ci-robot
Copy link

@Elbehery: This pull request references Jira Issue OCPBUGS-9908, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.11.z) matches configured target version for branch (4.11.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-8393 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-8393 targets the "4.12.z" version, which is one of the valid target versions: 4.12.0, 4.12.z
  • bug has dependents

Requesting review from QA contact:
/cc @geliu2016

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Mar 17, 2023
@openshift-ci openshift-ci bot requested a review from geliu2016 March 17, 2023 13:00
@Elbehery
Copy link
Contributor Author

@geliu2016 can you label this & verify please ?

@tjungblu
Copy link
Contributor

/test e2e-operator

1 similar comment
@Elbehery
Copy link
Contributor Author

/test e2e-operator

@Elbehery
Copy link
Contributor Author

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 18, 2023

@Elbehery: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 5bfd9ae into openshift:release-4.11 Mar 18, 2023
@openshift-ci-robot
Copy link

@Elbehery: Jira Issue OCPBUGS-9908: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-9908 has been moved to the MODIFIED state.

In response to this:

this is a manual cherrypick of #1016

resolves https://issues.redhat.com/browse/OCPBUGS-9908

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@tjungblu: #1022 failed to apply on top of branch "release-4.10":

Applying: OCPBUGS-9908: Garbage collect grafana-dashboard-etcd
Using index info to reconstruct a base tree...
M	hack/generate.sh
Falling back to patching base and 3-way merge...
Auto-merging hack/generate.sh
CONFLICT (content): Merge conflict in hack/generate.sh
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OCPBUGS-9908: Garbage collect grafana-dashboard-etcd
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Elbehery
Copy link
Contributor Author

@geliu2016 can we verify this as well ?

Please ignore 4.10 backport 👍🏽

@Elbehery Elbehery deleted the cherrypick-garbage-collect-grafana-dashboard branch February 14, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants